Skip to content

/ aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NER functionality. #470

Merged
merged 2 commits into from May 27, 2020
Merged

Remove NER functionality. #470

merged 2 commits into from May 27, 2020
+0 −539

Conversation

@ruebot
Copy link
Member

ruebot commented May 27, 2020

What does this Pull Request do?

Remove NER functionality.

  • Resolves #48
  • Resolves #52
  • Resolves #53
  • Resolves #469
  • Remove all NER associated functionality
  • Tweak pom.xml to handle the removal

How should this be tested?

TravisCI
@ruebot
Remove NER functionality.
Verified
This commit was signed with a verified signature.
ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
624c68c 
- Resolves #48
- Resolves #52
- Resolves #53
- Resolves #469
- Remove all NER associated functionality
- Tweak pom.xml to handle the removal
@ruebot ruebot requested a review from ianmilligan1 May 27, 2020
@ruebot
Merge branch 'master' into issue-469
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2645f5
@ruebot
Copy link
Member Author

ruebot commented May 27, 2020

Documentation update done by @ianmilligan1 here.
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #470 into master will increase coverage by 7.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   75.86%   83.35%   +7.49%     
==========================================
  Files          49       45       -4     
  Lines        1442     1304     -138     
  Branches      279      252      -27     
==========================================
- Hits         1094     1087       -7     
+ Misses        218       88     -130     
+ Partials      130      129       -1
@ianmilligan1
ianmilligan1 approved these changes May 27, 2020
View changes
@ianmilligan1
ianmilligan1 approved these changes May 27, 2020
View changes
@ianmilligan1 ianmilligan1 merged commit 060622c into master May 27, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 4322eb9...f2645f5
Details
codecov/project 83.35% (+7.49%) compared to 4322eb9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianmilligan1 ianmilligan1 added this to Done in 1.0.0 Release of AUT via automation May 27, 2020
@ianmilligan1 ianmilligan1 deleted the issue-469 branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
1.0.0 Release of AUT
  
Done
Test coverage
Awaiting triage
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove Extract Entities
Create tests for NERCombinedJson.scala
Create tests for NER3Classifier.scala
Create tests for ExtractEntities.scala
2 participants
@ruebot @ianmilligan1
You can’t perform that action at this time.