Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop-rspec to version 1.33.0 #71
+1
−1
Conversation
depfu
bot
added
the
depfu
label
May 14, 2019
This comment has been minimized.
This comment has been minimized.
|
@depfu rebase |
depfu
bot
force-pushed the
depfu/update/rubocop-rspec-1.33.0
branch
from
83e20f1
to
b709b75
May 24, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
May 24, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
@depfu rebase |
depfu
bot
force-pushed the
depfu/update/rubocop-rspec-1.33.0
branch
from
b709b75
to
a7b7cdc
May 24, 2019
ruebot
merged commit 9926313
into
master
May 24, 2019
depfu
bot
deleted the
depfu/update/rubocop-rspec-1.33.0
branch
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedMay 14, 2019
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
1.33.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 28 commits:
Merge pull request #766 from rubocop-hq/releaseBump version to v1.33.0Merge pull request #764 from rubocop-hq/drop-support-for-ruby-2.2Drop support for Ruby 2.2Merge pull request #763 from pirj/fix-blank-lines-in-multiple-subjectsFix blank lines produced by MultipleSubjects copMerge pull request #756 from renuo/fix-described-class-with-structsLet `RSpec/DescribedClass` pass `Struct` instantiation closuresMerge pull request #755 from rubocop-hq/fix-rubocop-offensesFix Naming/RescuedExceptionsVariableName offenseMerge pull request #732 from gsamokovarov/no-contextMerge pull request #746 from rubocop-hq/runners-in-language-moduleAdd RSpec/DialectUse `Runners::ALL` from the `Language` moduleAdd Runners to Language moduleMerge pull request #689 from thoughtbot/static-attribute-with-receiverEnforce dynamic attributes with explicit receiverMerge pull request #741 from rubocop-hq/remove-range-between-usageRemove `range_between` usage in favor of `with(end_pos: ...)`Merge pull request #738 from rubocop-hq/expect_correction-2Reword examples in hooks_before_examples_specUse expect_correction on more specsMerge pull request #737 from rubocop-hq/expect_correctionUse the new expect_correction spec helperMerge pull request #736 from toptal/fix-context-wording-to-support-metadataAdd support for metadata to ContextWordingMerge pull request #733 from rubocop-hq/extract-rspec-receiver-to-languageExtract RSpec receiver definition to Language moduleDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands