Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.72.0 #76

Merged
merged 1 commit into from Jun 26, 2019

Conversation

Projects
None yet
1 participant
@depfu
Copy link
Contributor

commented Jun 26, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.71.0 → ~> 0.72.0) · Repo · Changelog

Release Notes

0.72.0

New features

Bug fixes

  • #7121: Fix Style/TernaryParentheses cop to allow safe navigation operator without parentheses. (@timon)
  • #7063: Fix autocorrect in Style/TernaryParentheses cop. (@parkerfinch)
  • #7106: Fix an error for Lint/NumberConversion when #to_i called on a variable on a hash. (@koic)
  • #7107: Fix parentheses offence for numeric arguments with an operator in Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #7119: Fix cache with non UTF-8 offense message. (@pocke)
  • #7118: Fix Style/WordArray with encoding: binary magic comment and non-ASCII string. (@pocke)
  • #7159: Fix an error for Lint/DuplicatedKey when using endless range. (@koic)
  • #7151: Fix Style/WordArray to also consider words containing hyphens. (@fwitzke)
  • #6893: Handle implicit rescue correctly in Naming/RescuedExceptionsVariableName. (@pocke, @anthony-robin)
  • #7165: Fix an auto-correct error for Style/ConditionalAssignment when without else branch'. (@koic)
  • #7171: Fix an error for Style/SafeNavigation when using unless nil? as a safeguarded'. (@koic)
  • #7113: This PR renames EnforcedStyle: rails to EnabledStyle: outdented_access_modifiers for Layout/IndentationConsistency. (@koic)
  • #7130: Skip autocorrect in Style/FormatString if second argument to String#% is a variable. (@tejasbubane)
  • #7171: Fix an error for Style/SafeNavigation when using unless nil? as a safeguarded'. (@koic)

Changes

  • #5976: Remove Rails cops. (@koic)
  • #5976: Remove rubocop -R/--rails option. (@koic)
  • #7113: Rename EnforcedStyle: rails to EnabledStyle: indented_internal_methods for Layout/IndentationConsistency. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 54 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 26, 2019

@ruebot ruebot merged commit f8effa0 into master Jun 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/rubocop-0.72.0 branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.