Skip to content

/warclight

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.75.0 #86

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@depfu
Copy link
Contributor

commented Oct 1, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.74.0 → ~> 0.75.0) · Repo · Changelog

Release Notes

0.75.0

New features

  • #7274: Add new Lint/SendWithMixinArgument cop. (@koic)
  • #7272: Show warning message if passed string to Enabled, Safe, SafeAutocorrect, and AutoCorrect keys in .rubocop.yml. (@unasuke)
  • #7295: Make it possible to set StyleGuideBaseURL per department. (@koic)
  • #7301: Add check for calls to remote_byebug to Lint/Debugger cop. (@riley-klingler)
  • #7321: Allow YAML aliases in .rubocop.yml. (@raymondfallon)
  • #7317: Add new formatter pacman. (@crojasaragonez)
  • #6075: Support IgnoredPatterns option for Naming/MethodName cop. (@koic)
  • #7335: Add todo as an alias to disable. --disable-uncorrectable will now disable cops using rubocop:todo instead of rubocop:disable. (@desheikh)

Bug fixes

  • #7256: Fix an error of Style/RedundantParentheses on method calls where the first argument begins with a hash literal. (@halfwhole)
  • #7263: Make Layout/SpaceInsideArrayLiteralBrackets properly handle tab-indented arrays. (@buehmann)
  • #7252: Prevent infinite loops by making Layout/SpaceInsideStringInterpolation skip over interpolations that start or end with a line break. (@buehmann)
  • #7262: Lint/FormatParameterMismatch did not recognize named format sequences like %.2<name>f where the name appears after some modifiers. (@buehmann)
  • #7253: Fix an error for Lint/NumberConversion when #to_i called without a receiver. (@koic)
  • #7271, #6498: Fix an interference between Style/TrailingCommaIn*Literal and Layout/Multiline*BraceLayout for arrays and hashes. (@buehmann)
  • #7241: Make Style/FrozenStringLiteralComment match only true & false. (@tejasbubane)
  • #7290: Handle inner conditional inside else in Style/ConditionalAssignment. (@jonas054)
  • #5788: Allow block arguments on separate lines if line would be too long in Layout/MultilineBlockLayout. (@jonas054)
  • #7305: Register Style/BlockDelimiters offense when block result is assigned to an attribute. (@mvz)
  • #4802: Don't leave any Lint/UnneededCopEnableDirective offenses undetected/uncorrected. (@jonas054)
  • #7326: Fix a false positive for Style/AccessModifierDeclarations when access modifier name is used for hash literal value. (@koic)
  • #3591: Handle modifier if/unless correctly in Lint/UselessAssignment. (@jonas054)
  • #7161: Fix Style/SafeNavigation cop for preserve comments inside if expression. (@tejasbubane)
  • #5212: Avoid false positive for braces that are needed to preserve semantics in Style/BracesAroundHashParameters. (@jonas054)
  • #7353: Fix a false positive for Style/RedundantSelf when receiver and multiple assigned lvalue have the same name. (@koic)
  • #7353: Fix a false positive for Style/RedundantSelf when a self receiver is used as a method argument. (@koic)
  • #7358: Fix an incorrect autocorrect for Style/NestedModifier when parentheses are required in method arguments. (@koic)
  • #7361: Fix a false positive for Style/TernaryParentheses when only the closing parenthesis is used in the last line of condition. (@koic)
  • #7369: Fix an infinite loop error for Layout/IndentAssignment with Layout/IndentFirstArgument when using multiple assignment. (@koic)
  • #7177, #7370: When correcting alignment, do not insert spaces into string literals. (@buehmann)
  • #7367: Fix an error for Style/OrAssignment cop when then branch body is empty. (@koic)
  • #7363: Fix an incorrect autocorrect for Layout/SpaceInsideBlockBraces and Style/BlockDelimiters when using multiline empty braces. (@koic)
  • #7212: Fix a false positive for Layout/EmptyLinesAroundAccessModifier and UselessAccessModifier when using method with the same name as access modifier around a method definition. (@koic)

Changes

  • #7312: Mark Style/StringHashKeys as unsafe. (@prathamesh-sonpatki)
  • #7275: Make Style/VariableName aware argument names when invoking a method. (@koic)
  • #3534: Make Style/IfUnlessModifier report and auto-correct modifier lines that are too long. (@jonas054)
  • #7261: Style/FrozenStringLiteralComment no longer inserts an empty line after the comment. This is left to Layout/EmptyLineAfterMagicComment. (@buehmann)
  • #7091: Style/FormatStringToken now detects format sequences with flags and modifiers. (@buehmann)
  • #7319: Rename IgnoredMethodPatterns option to IgnoredPatterns option for Style/MethodCallWithArgsParentheses. (@koic)
  • #7345: Mark unsafe for Style/YodaCondition. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu
Update rubocop to version 0.75.0
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
643d4d9
@depfu depfu bot added the depfu label Oct 1, 2019
@codecov

This comment has been minimized.

Sign in to view
Copy link

commented Oct 1, 2019 •
edited

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #86   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b783608...643d4d9. Read the comment docs.
@ruebot ruebot merged commit ed25142 into master Oct 1, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing b783608...643d4d9
Details
codecov/project 100% remains the same compared to b783608
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@depfu depfu bot deleted the depfu/update/rubocop-0.75.0 branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
1 participant
@ruebot
You can’t perform that action at this time.