Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: cppduals: a nestable vectorized templated dual number library for C++11 #1446

Closed
whedon opened this issue May 13, 2019 · 32 comments

Comments

Projects
None yet
8 participants
@whedon
Copy link
Collaborator

commented May 13, 2019

Submitting author: @tesch1 (Michael Tesch)
Repository: https://gitlab.com/tesch1/cppduals
Version: v0.1.0
Editor: @danielskatz
Reviewers: @StewMH, @mdavezac

Author instructions

Thanks for submitting your paper to JOSS @tesch1. Currently, there isn't an JOSS editor assigned to your paper.

@tesch1 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label May 13, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 13, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 13, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 13, 2019

@arfon

This comment has been minimized.

Copy link
Member

commented May 13, 2019

👋 @tesch1 - thanks for your submission to JOSS.

After giving your paper a quick read, I think it would be good to expand a little on this bullet from our paper requirements:

A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience

We also have this requirement for our papers:

Mentions (if applicable) of any ongoing research projects using the software or recent scholarly publications enabled by it.

Are there ongoing research projects that make use of this software?

@tesch1

This comment has been minimized.

Copy link

commented May 14, 2019

@arfon

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2019

@arfon

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I've recalibrated the summary a bit, is there anything more specific about what kind of diverse non-specialist audience is intended?

Thanks, I think that addition to the introduction helps.

Could you take a look at this list of potential reviewers and identify any good candidates to review this submission?

@arfon

This comment has been minimized.

Copy link
Member

commented May 18, 2019

@danielskatz - would you be able to edit this submission?

@danielskatz

This comment has been minimized.

Copy link

commented May 18, 2019

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 18, 2019

OK, the editor is @danielskatz

@danielskatz

This comment has been minimized.

Copy link

commented May 18, 2019

👋 @tesch1 - I repeat Arfon's request:

Could you take a look at this list of potential reviewers and identify any good candidates to review this submission?

@tesch1

This comment has been minimized.

Copy link

commented May 18, 2019

@danielskatz

This comment has been minimized.

Copy link

commented May 23, 2019

👋 @tesch1 - Any suggestions?

@tesch1

This comment has been minimized.

Copy link

commented May 27, 2019

Perhaps @leios, @vyasr, @mlxd, or @StewMH would be good?

@danielskatz

This comment has been minimized.

Copy link

commented May 27, 2019

👋 @leios, @vyasr, @mlxd, or @StewMH - would a couple of you be willing to review this for JOSS? Or if not, would you have suggestions for others who might be good fits?

@StewMH

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

Hi Dan, Michael,

I'd be happy to review it.

Cheers,
Stewart

@danielskatz

This comment has been minimized.

Copy link

commented May 28, 2019

Thanks @StewMH - as soon as we get one more reviewer, we will start the actual review.

@danielskatz

This comment has been minimized.

Copy link

commented May 28, 2019

@whedon assign @StewMH as reviewer

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented May 28, 2019

OK, the reviewer is @StewMH

@mlxd

This comment has been minimized.

Copy link

commented May 28, 2019

Sorry @tesch1 @danielskatz , don't think that I will have time for the coming 3 weeks.
If things haven't moved forward by then, I'll be happy to jump in.

@danielskatz

This comment has been minimized.

Copy link

commented May 28, 2019

Thanks @mlxd - let's see if we can find someone else in this case

@danielskatz

This comment has been minimized.

Copy link

commented May 30, 2019

👋 @poulson and @VivianePons - can you help with suggestions for a second reviewer for this submission?

@danielskatz

This comment has been minimized.

Copy link

commented Jun 4, 2019

👋 @mdavezac - you've been suggested as the perfect reviewer for this. Would you be willing to do this? (see JOSS reviewer guidelines)

@vyasr

This comment has been minimized.

Copy link

commented Jun 5, 2019

Sorry I haven't been more responsive, I unfortunately won't be available to review this paper.

@mdavezac

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

I'd be happy to review it.

@danielskatz

This comment has been minimized.

Copy link

commented Jun 5, 2019

Great, thanks - we'll start the review now then

@danielskatz

This comment has been minimized.

Copy link

commented Jun 5, 2019

@whedon add @mdavezac as reviewer

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 5, 2019

OK, @mdavezac is now a reviewer

@danielskatz

This comment has been minimized.

Copy link

commented Jun 5, 2019

@whedon start review

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 5, 2019

OK, I've started the review over in #1487. Feel free to close this issue now!

@danielskatz danielskatz closed this Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.