Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport for OAuth based SSH Channels #944
Conversation
yadudoc
added some commits
Mar 13, 2019
yadudoc
requested review from
annawoodard and
ZhuozhaoLi
May 16, 2019
benclifford
reviewed
May 17, 2019
benclifford
reviewed
May 17, 2019
benclifford
reviewed
May 17, 2019
benclifford
reviewed
May 17, 2019
setup.py Outdated
yadudoc
added some commits
May 17, 2019
This comment has been minimized.
This comment has been minimized.
|
This is failing with a mypy error at the moment as mypy cannot find type information for the oauth client. |
yadudoc
added some commits
May 21, 2019
annawoodard
reviewed
May 28, 2019
yadudoc
added this to the Parsl-0.8.0 milestone
May 29, 2019
yadudoc
added some commits
May 29, 2019
ZhuozhaoLi
approved these changes
May 29, 2019
yadudoc
merged commit 0e7921d
into
master
May 29, 2019
1 check passed
Travis CI - Pull Request
Build Passed
Details
yadudoc
deleted the
globus_ssh
branch
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
yadudoc commentedMay 16, 2019
We are using the
oauth-sshmodule from https://github.com/XSEDE/oauth-ssh/tree/master/client for this new channel.I've only done very limited testing with this, so there are still rough edges and errors are probably not handled quite well. There's also a test script in
parsl/tests/manual_tests/test_oauth_ssh.pythat should help with testing the channel on it's own.