Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly trigger TravisCI on master. #283
Conversation
ruebot
requested a review
from
ianmilligan1
Oct 17, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Oct 17, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 41 41
Lines 1046 1046
Branches 192 192
=======================================
Hits 736 736
Misses 244 244
Partials 66 66Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Oct 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Do you want to update the branch and then I can merge? |
ianmilligan1
merged commit 0d4f9bb
into
archivesunleashed:master
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedOct 17, 2018
GitHub issue(s): N/A (Slack conversation)
What does this Pull Request do?
Update TravisCI to just run on master, and PRs against master.
How should this be tested?
TravisCI should get triggered. After this is merged, we should push another branch, and see if TravisCi gets triggered.