Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSheldon build details: upgrade to shel-bot, and embedded shel-gem #15
+429
−22
Conversation
retorquere
added some commits
May 28, 2019
retorquere
added some commits
Jun 6, 2019
This comment has been minimized.
This comment has been minimized.
|
@rmzelle let me know how involved you want to be with the review of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
retorquere commentedJun 7, 2019
The PR hosts two parts of the upgrade to Sheldon to post build details on github:
details, where the build details can be PUT tosheldon), which posts the build details to that endpointThe
stylesandlocalesrepo will have to call the latter to activate this; PRs for those are incoming. Shel-bot is backwards compatible, so this should be safe to roll out.My apologies for the long commit list but the most efficient way for me to test was to commit and push to heroku, and I needed a lot of tests before I found a way that worked.