Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unused "detectImport" #1916

Merged
merged 5 commits into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@retorquere
Copy link
Contributor

commented Mar 28, 2019

no-unused-vars also applies to functions and therefore reports (detect|do)(Export|Web|Import) as problems, because they're not called within the body of the translator. Also, I misnamed detectImport as doDetect.

retorquere added some commits Mar 28, 2019

@retorquere

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

OK, fixed.

Show resolved Hide resolved .eslintrc
@dstillman

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

But I'm not clear what this is actually doing. Can you explain?

@retorquere

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

It checks consistency of what a translator declared it will do by its translatortype, and what it actually does in terms of handlers.

@dstillman dstillman merged commit a6a8426 into zotero:master Apr 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@retorquere retorquere deleted the retorquere:patch-1 branch Apr 1, 2019

adam3smith added a commit that referenced this pull request Apr 1, 2019

dstillman added a commit that referenced this pull request Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.