New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales-lt-LT.xml with genders #155

Merged
merged 3 commits into from Jan 22, 2017

Conversation

Projects
None yet
4 participants
@rmzelle
Member

rmzelle commented Jan 22, 2017

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Jan 22, 2017

Awesome! You've created a pull request to the Citation Styles Language locales repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your locale file validates.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

csl-bot commented Jan 22, 2017

Awesome! You've created a pull request to the Citation Styles Language locales repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your locale file validates.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Jan 22, 2017

Uh-oh! Looks like there are (still) some issues with your submission. Please check the latest test report for details.

csl-bot commented Jan 22, 2017

Uh-oh! Looks like there are (still) some issues with your submission. Please check the latest test report for details.

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Jan 22, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

csl-bot commented Jan 22, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Jan 22, 2017

Member

@embar-, @aurimasv, can you review this? I took @aurimasv's version, and then removed anything that wasn't valid CSL 1.0.1 (per http://docs.citationstyles.org/en/stable/specification.html#gender-specific-ordinals, it's only allowed to specify a gender for the long form of CSL number variable terms and months terms).

Apart from the gender assignments, the ordinal terms are changed, and a translator for "illustrator".

Member

rmzelle commented Jan 22, 2017

@embar-, @aurimasv, can you review this? I took @aurimasv's version, and then removed anything that wasn't valid CSL 1.0.1 (per http://docs.citationstyles.org/en/stable/specification.html#gender-specific-ordinals, it's only allowed to specify a gender for the long form of CSL number variable terms and months terms).

Apart from the gender assignments, the ordinal terms are changed, and a translator for "illustrator".

@embar-

This comment has been minimized.

Show comment
Hide comment
@embar-

embar- Jan 22, 2017

Contributor

Gender definitions are good. But as said in #153 (comment) and in #153 (comment) , we don't need genders for dates; if it will be used, then gender of day (as digit) depends on word "diena" (eng. "day", feminine), not on month (mixed genders).

We should keep "ordinal-03" and "ordinal-13" definitions in 78-79 lines.
At 275 line we should keep "iliustr."; see foe example http://internet.unib.ktu.lt/chemija_lt/suda_lite.htm

Contributor

embar- commented Jan 22, 2017

Gender definitions are good. But as said in #153 (comment) and in #153 (comment) , we don't need genders for dates; if it will be used, then gender of day (as digit) depends on word "diena" (eng. "day", feminine), not on month (mixed genders).

We should keep "ordinal-03" and "ordinal-13" definitions in 78-79 lines.
At 275 line we should keep "iliustr."; see foe example http://internet.unib.ktu.lt/chemija_lt/suda_lite.htm

@embar-

This comment has been minimized.

Show comment
Hide comment
@embar-

embar- Jan 22, 2017

Contributor

We could also add
<term name="ordinal-03" gender-form="masculine">-iasis</term>
<term name="ordinal-13" gender-form="masculine">-asis</term>
<term name="ordinal-03" gender-form="feminine">-ioji</term>
<term name="ordinal-13" gender-form="feminine">-oji</term>

Contributor

embar- commented Jan 22, 2017

We could also add
<term name="ordinal-03" gender-form="masculine">-iasis</term>
<term name="ordinal-13" gender-form="masculine">-asis</term>
<term name="ordinal-03" gender-form="feminine">-ioji</term>
<term name="ordinal-13" gender-form="feminine">-oji</term>

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Jan 22, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

csl-bot commented Jan 22, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Jan 22, 2017

Member

How about now?

Member

rmzelle commented Jan 22, 2017

How about now?

@embar-

This comment has been minimized.

Show comment
Hide comment
@embar-

embar- Jan 22, 2017

Contributor

Thanks, this is very good!

Contributor

embar- commented Jan 22, 2017

Thanks, this is very good!

@rmzelle

This comment has been minimized.

Show comment
Hide comment
@rmzelle

rmzelle Jan 22, 2017

Member

Great. I'll merge this once I get the okay from @aurimasv as well. (Sorry if I was a bit slow in catching up; I don't know anything about Lithuanian)

I removed the genders from the month terms, since it would just lead to confusion, because CSL currently assumes that the day number in ordinal form follows the gender of the month, which you indicated is not the case for Lithuanian. We could assign the "feminine" gender to all "month" terms to hack around this (since "diena" is feminine), but that's also confusing, so I rather leave things as they are. If anybody really would like proper support, we should amend the CSL specification instead.

Member

rmzelle commented Jan 22, 2017

Great. I'll merge this once I get the okay from @aurimasv as well. (Sorry if I was a bit slow in catching up; I don't know anything about Lithuanian)

I removed the genders from the month terms, since it would just lead to confusion, because CSL currently assumes that the day number in ordinal form follows the gender of the month, which you indicated is not the case for Lithuanian. We could assign the "feminine" gender to all "month" terms to hack around this (since "diena" is feminine), but that's also confusing, so I rather leave things as they are. If anybody really would like proper support, we should amend the CSL specification instead.

@aurimasv

This comment has been minimized.

Show comment
Hide comment
@aurimasv

aurimasv Jan 22, 2017

Contributor
Contributor

aurimasv commented Jan 22, 2017

@rmzelle rmzelle merged commit 8bbfa39 into master Jan 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rmzelle rmzelle deleted the rmzelle-lt branch Jan 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment