New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bursa-uludag-universitesi-saglik-bilimleri-enstitusu.csl #3778

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@ozhansaglik
Contributor

ozhansaglik commented Nov 12, 2018

We need to exclude (Turkish) from the title.

Update bursa-uludag-universitesi-saglik-bilimleri-enstitusu.csl
We need to exclude (Turkish) from the title.
@csl-bot

This comment has been minimized.

csl-bot commented Nov 12, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

csl-bot commented Nov 12, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Member

adam3smith commented Nov 13, 2018

All CSL styles with a non-English decault locale have the language in parentheses in the repository. Why would you want to remove it?

@ozhansaglik

This comment has been minimized.

Contributor

ozhansaglik commented Nov 13, 2018

Because our other styles do not include Turkish in parentheses.

mendeley_desktop

@rmzelle

This comment has been minimized.

Member

rmzelle commented Nov 13, 2018

@ozhansaglik, like @adam3smith says, we always include the language in the title for CSL styles fixed to a non-English language.

In your recent update of the "Bursa Uludağ Üniversitesi - Sağlık Bilimleri Enstitüsü" style (#3767), you added default-locale="tr-TR" to that style, which fixes the style to Turkish. As a result, we added the "(Turkish)" to the style title.

Was the addition of default-locale="tr-TR" an intentional change? When you first contributed the styles for Bursa Uludağ Üniversitesi, you indicated that the styles could also be used in English (#3715 (comment)), in which case we wouldn't want to fix any of the styles to Turkish.

@ozhansaglik

This comment has been minimized.

Contributor

ozhansaglik commented Nov 13, 2018

It is my fault sorry for the disturbance. I did not add "default-locale="tr-TR" intentionally, also I did not examine if there is a code like this.

Can you delete it or I have to delete it?

Sorry again.

Best

Özhan

@rmzelle

This comment has been minimized.

Member

rmzelle commented Nov 13, 2018

I just reverted the change: 41cb8d2

Should show up in Zotero/Mendeley within a day.

@rmzelle rmzelle closed this Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment