Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdated modern-language-association.csl #3861
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 7, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 7, 2019
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, do you mind checking this? (do you have a copy of the MLA styleguide?) It might make more sense to fold the "director" code into the "other-contributors" macro, since that seems to be how MLA structures its citations at the highest level (see https://style.mla.org/works-cited-a-quick-guide/). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 17, 2019
|
rmzelle
assigned
adam3smith
Jan 20, 2019
rmzelle
added some commits
Jan 20, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 20, 2019
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, haven't checked the style guide, but this is how I would add director support. Please merge if it looks okay. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 20, 2019
|
This comment has been minimized.
This comment has been minimized.
Thanks -- I have the manual in the office, will check & merge or adjust on Tuesday |
This comment has been minimized.
This comment has been minimized.
@adam3smith Does it fit the manual specifications? I do not have a copy. If it is all good, I can go ahead and close #3675. |
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Mar 21, 2019
This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks. |
stale
bot
added
the
waiting
label
Mar 21, 2019
stale
bot
closed this
Apr 4, 2019
adam3smith
reopened this
Apr 4, 2019
stale
bot
removed
the
waiting
label
Apr 4, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 4, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 14, 2019
|
adam3smith
merged commit 9bf39c0
into
citation-style-language:master
Apr 15, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
Really sorry this took so long. Part of this was the MLA's film citation rules are quite confusing -- directors etc. can also be listed in the author position, but for generic citations, this is the right format. |
This comment has been minimized.
This comment has been minimized.
Yes, I believe if you want to emphasize a director or performer you place it in the author position. Thank you for checking the specifications in the MLA Handbook. |
avimshah commentedJan 7, 2019
Add support for motion picture director CSL name-variable to MLA 8th edition style. Closes #3675.
Example Output: Ready Player One. Directed by Steven Spielberg, Warner Bros., 2018.