Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated modern-language-association.csl #3861

Merged
merged 5 commits into from Apr 15, 2019

Conversation

Projects
None yet
4 participants
@avimshah
Copy link
Contributor

avimshah commented Jan 7, 2019

Add support for motion picture director CSL name-variable to MLA 8th edition style. Closes #3675.

Example Output: Ready Player One. Directed by Steven Spielberg, Warner Bros., 2018.

Added CSL "Director" Name-Variable support
Add support for motion picture director name-variable in MLA8.
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 7, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 7, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 9, 2019

@adam3smith, do you mind checking this? (do you have a copy of the MLA styleguide?)

It might make more sense to fold the "director" code into the "other-contributors" macro, since that seems to be how MLA structures its citations at the highest level (see https://style.mla.org/works-cited-a-quick-guide/).

Revert removal of line for no locator label
get rid of stray space
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 17, 2019

😃 Your submission passed all our automated tests.

rmzelle added some commits Jan 20, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 20, 2019

😟 There are some issues with your submission. Please check the test report for details.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 20, 2019

@adam3smith, haven't checked the style guide, but this is how I would add director support. Please merge if it looks okay.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 20, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 20, 2019

Thanks -- I have the manual in the office, will check & merge or adjust on Tuesday

@avimshah

This comment has been minimized.

Copy link
Contributor Author

avimshah commented Feb 19, 2019

@adam3smith Does it fit the manual specifications? I do not have a copy. If it is all good, I can go ahead and close #3675.

@stale

This comment has been minimized.

Copy link

stale bot commented Mar 21, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Mar 21, 2019

@stale stale bot closed this Apr 4, 2019

@adam3smith adam3smith reopened this Apr 4, 2019

@stale stale bot removed the waiting label Apr 4, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 4, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 14, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 9bf39c0 into citation-style-language:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Apr 15, 2019

Really sorry this took so long. Part of this was the MLA's film citation rules are quite confusing -- directors etc. can also be listed in the author position, but for generic citations, this is the right format.

@avimshah

This comment has been minimized.

Copy link
Contributor Author

avimshah commented Apr 15, 2019

Yes, I believe if you want to emphasize a director or performer you place it in the author position. Thank you for checking the specifications in the MLA Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.