Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ecole-doctorale-de-sciences-po-author-date-french.csl #3869

Merged
merged 11 commits into from Apr 19, 2019

Conversation

Projects
None yet
4 participants
@AnnaCouthuresIdrizi
Copy link
Contributor

AnnaCouthuresIdrizi commented Jan 10, 2019

No description provided.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 10, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 10, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 10, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 12, 2019

Thanks! Is the style guide for this citation format available online? We try to always include a "documentation" link in our repository styles. See https://github.com/citation-style-language/styles/wiki/Style-Requirements#10---documentation-link as well.

Same holds for #3868.

@AnnaCouthuresIdrizi

This comment has been minimized.

Copy link
Contributor Author

AnnaCouthuresIdrizi commented Jan 14, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 15, 2019

(I'm happy to merge this before the styleguide goes live, but there are some quality issues with the style code, so please don't quite merge yet). Will review in detail tomorrow

@adam3smith
Copy link
Member

adam3smith left a comment

Thanks! A bunch of comments & suggested improvements in line. Please apply the same ideas to your other style submission.

<names variable="author">
<name form="short" and="text" delimiter-precedes-last="never" sort-separator=" " font-style="normal">
</name>
</names>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 17, 2019

Member

let's handle this with substitute, please

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 5, 2019

Author Contributor

i don't understand how to do that

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 11, 2019

Author Contributor

could you help me, please ?

<names variable="author">
<name form="long" and="text" name-as-sort-order="first" sort-separator=", " font-style="normal">
<name-part name="family" font-variant="small-caps"/>
</name>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 17, 2019

Member

ditto here -- editor should just be in substitute

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 5, 2019

Author Contributor

i don't understand how to do that

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 11, 2019

Author Contributor

could you help me, please ?

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 28, 2019

Author Contributor

Dear all, for a lot of items, i just copied/pasted elements from other styles already in your repository. I do not understand why i should have to correct those elements.
If it's really necessary to correct them, could you please help me ?
Best regards,
Anna

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 28, 2019

Member

Yes, if you want a style hosted by us, which goes out to software with hundreds of thousands of end users, we absolutely insist on quality control on submission. If you want to have the style available, you can always self-host it.

We do this on a volunteer basis, so if you need significant help -- as in this case, where you essentially ask me to explain almost every change request -- this may take a bit longer, sorry.

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Apr 10, 2019

Author Contributor

Dear Sebastian,
Thank you so much for your help !
I'm already volunteer for other academic subjects, and i'm well aware that people write you only when they have a problem or a claim ; so i deeply apologize if my last email hurted you, that was not the scope.
Now that you fixed all issues, what is the next step ? Can both styles (author date & note) be shared through styles repository ?
Best regards,
Anna

<macro name="access">
<choose>
<if type="article article-journal article-magazine article-newspaper book broadcast chapter entry-dictionary entry-encyclopedia thesis graphic legal_case legislation manuscript map motion_picture paper-conference patent post post-weblog personal_communication report song speech webpage" match="any">
<text variable="URL" prefix="En ligne : " suffix=" "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 17, 2019

Member

This should all be wrapped into an if variable="URL" test to avoid getting just the accessed date

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 5, 2019

Author Contributor

i don't understand how to do that

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 11, 2019

Author Contributor

could you help me, please ?

</else-if>
<else-if type="chapter entry-dictionary entry-encyclopedia" match="any">
<group>
<group suffix=" ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 17, 2019

Member

remove this group and set a delimiter=" " on the outer group for the spacing.

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 5, 2019

Author Contributor

i don't understand how to do that

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 11, 2019

Author Contributor

could you help me, please ?

Show resolved Hide resolved ecole-doctorale-de-sciences-po-author-date-french.csl Outdated
<macro name="collection">
<choose>
<if is-numeric="collection-number">
<text variable="collection-title" prefix="(" suffix=""/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 17, 2019

Member

let's put these two in a group with the parentheses around the group.

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 5, 2019

Author Contributor

i don't understand how to do that

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 11, 2019

Author Contributor

could you help me, please ?

Show resolved Hide resolved ecole-doctorale-de-sciences-po-author-date-french.csl Outdated
Show resolved Hide resolved ecole-doctorale-de-sciences-po-author-date-french.csl Outdated
<if position="ibid-with-locator">
<group delimiter=", ">
<text term="ibid" text-case="capitalize-first" font-style="italic" suffix="."/>
<text variable="locator" prefix="p. "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 17, 2019

Member

as above, use label instead (also, presumably should be nbsp?)

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 5, 2019

Author Contributor

i don't understand how to do that

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 11, 2019

Author Contributor

could you help me, please ?

<key variable="issued" sort="descending"/>
</sort>
<layout>
<text macro="author" suffix=". "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jan 17, 2019

Member

more elegant to handle all of these suffixes with a single delimiter=". "

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 5, 2019

Author Contributor

i don't understand how to do that

This comment has been minimized.

Copy link
@AnnaCouthuresIdrizi

AnnaCouthuresIdrizi Mar 11, 2019

Author Contributor

could you help me, please ?

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 19, 2019

@AnnaCouthuresIdrizi, let us know if you need any help implementing @adam3smith's suggestions. We'd like to include these before accepting the style.

And I see that https://sciencespo.libguides.com/zotero/styles is now online. Does the website describe the note and author-date citation formats itself anywhere? I briefly looked around but didn't see any examples of what citations should look like.

@stale

This comment has been minimized.

Copy link

stale bot commented Feb 18, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Feb 18, 2019

@AnnaCouthuresIdrizi

This comment has been minimized.

Copy link
Contributor Author

AnnaCouthuresIdrizi commented Feb 26, 2019

@stale stale bot removed the waiting label Feb 26, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Feb 26, 2019

Could you specify where you need help/additional information? Just reply to my comments.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 5, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 5, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 5, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 5, 2019

😃 Your submission passed all our automated tests.

@AnnaCouthuresIdrizi

This comment has been minimized.

Copy link
Contributor Author

AnnaCouthuresIdrizi commented Mar 13, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 3, 2019

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

adam3smith left a comment

OK, I was able to fix most things, but one question remaining

<if type="bill book chapter entry-dictionary entry-encyclopedia thesis legal_case manuscript map paper-conference song" match="any">
<choose>
<if variable="publisher-place" match="any">
<text variable="publisher-place" suffix=" : "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Apr 3, 2019

Member

@AnnaCouthuresIdrizi -- I don't understand why this is marked as resolved? If I'm wrong about the above, you'd need to say why. I'm very skeptical that the code as is produces correct output.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 3, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 3, 2019

😟 There are some issues with your submission. Please check the test report for details.

Update and rename ecole-doctorale-de-sciences-po-author-date-french.c…
…sl to sciences-po-ecole-doctorale-author-date.csl
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 9, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Apr 9, 2019

(@adam3smith, the related #3868 automatically closed because of inactivity)

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 19, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 3e897d2 into citation-style-language:master Apr 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Apr 20, 2019

Sorry for the wait. @AnnaCouthuresIdrizi if you want the note version added as well, you'd have to make the analogous changes implemented here on that style: #3868 . Let me know if you want me to reopen that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.