Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create KatiGel Diplomarbeit ÖNORM #3929

Merged
merged 2 commits into from Apr 19, 2019

Conversation

Projects
None yet
4 participants
@gschachinger
Copy link
Contributor

gschachinger commented Feb 10, 2019

Please upload to Zotero public citation styles so that all students are able to use this style for their diploma thesis

Create KatiGel Diplomarbeit ÖNORM
Please upload to Zotero public citation styles so that all students are able to use this style for their diploma thesis
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 10, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 10, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Feb 10, 2019

Thank you. My question from one of the other pull requests for documentation of the citation format remains relevant though: We are reluctant to accept styles with no available documentation since that means they cannot be checked or maintained beyond the original creator. If the style isn't available online, is there a document you could upload here?

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 17, 2019

(supersedes #3924, #3925, #3926, #3927, and #3928; @gschachinger, for the future, please note that you can update pull requests per the instructions above. There is generally no need to create new pull requests if the first one gives an error for our automated tests)

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Feb 17, 2019

@gschachinger, I just noticed that we already have a "TGM Wien Diplomarbeit" style in the repository that was contributed by you several years ago. See https://github.com/citation-style-language/styles/blob/master/tgm-wien-diplom.csl. Is the style you're submitting now meant to replace our current version, or are they two different citation styles?

(@adam3smith, you actually added this way back in 2011: 837a793#diff-8495915906ba1fa0d34d04e95e36189c )

@stale

This comment has been minimized.

Copy link

stale bot commented Mar 19, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Mar 19, 2019

@stale stale bot closed this Apr 2, 2019

@gschachinger

This comment has been minimized.

Copy link
Contributor Author

gschachinger commented Apr 2, 2019

@adam3smith adam3smith reopened this Apr 3, 2019

@stale stale bot removed the waiting label Apr 3, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 3, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Apr 3, 2019

The two remaining questions are this from me:

Thank you. My question from one of the other pull requests for documentation of the citation format remains relevant though: We are reluctant to accept styles with no available documentation since that means they cannot be checked or maintained beyond the original creator. If the style isn't available online, is there a document you could upload here?

We don't have any doubt that this style is authorized, but we still would much prefer to have some sort of public documentation. If someone reports a problem with the style, for example, we don't want to have to rely on being able to contact you to clarify.

And this from Rintze:

I just noticed that we already have a "TGM Wien Diplomarbeit" style in the repository that was contributed by you several years ago. See https://github.com/citation-style-language/styles/blob/master/tgm-wien-diplom.csl. Is the style you're submitting now meant to replace our current version, or are they two different citation styles?

Obviously we don't want to unnecessarily host duplicate or quasi-duplicate styles.

@gschachinger

This comment has been minimized.

Copy link
Contributor Author

gschachinger commented Apr 6, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Apr 6, 2019

Great thanks -- unfortunately attachments sent by email don't upload here. You'd have to go to #3929 , log in, and then upload them (simply by dragging the file(s) to the comment window.

@gschachinger

This comment has been minimized.

Copy link
Contributor Author

gschachinger commented Apr 6, 2019

doc-zitiervorlage-tgm-wien-diplom-oenorm.pdf
tgm-wien-diplom-oenorm.zip

According to your mail adam3smith, here again the attachments. The new title of the style is:
TGM Wien Diplomarbeit ÖNORM (German)
Please be so kind and change the name of the style which is included in the zip csl File
I hope now everything is OK with the new, second style.

@gschachinger

This comment has been minimized.

Copy link
Contributor Author

gschachinger commented Apr 6, 2019

So finaly there should be online 2 styles:
TGM Wien Diplomarbeit ÖNORM (German) => the "second" TGM style
TGM Wien Diplomarbeit (German) => the "first" TGM style

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Apr 19, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit dbbc26d into citation-style-language:master Apr 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.