Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

😟 There are some issues with your submission. Please check the test report for details.

😃 Your submission passed all our automated tests.

Hello,

Do you think there is a chance that our vancouver style for the students of the faculty of Biology and Medicine at the Lausanne University (UNIL) would be accepted into the Zotero repository ?

The CSL style did pass all the automated checks last week but I was wondering if maybe I had to make other corrections. Or if you consider this style would not be eligible ?

Many thanks for all your work.

Alex

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

Apologies for the long wait -- will look asap

Apologies for the long wait -- will look asap

No problems. Thank you!

😃 Your submission passed all our automated tests.

@rmzelle could you check metadata & merge please? Not sure about naming here.

😃 Your submission passed all our automated tests.

Thanks! (@alerac, I changed the title and file name a little to be more in line with the rest of our styles)

Thanks! (@alerac, I changed the title and file name a little to be more in line with the rest of our styles)

Many thanks to you @rmzelle! Ok no problems!

@adam3smith Many thanks also for the clean-up and reformat referenced here

I will just close my fork and propose an update with a new pull request soon. Because in the corrections you made (line 517 removed) the <text variable="note" suffix=" "/> should be present. I managed to have the webpage date (if any) in the Extra field in addition to the website date.

if the line <text variable="note" suffix=" "/> is not present the reference is then not correct. Below an image showing this. Reference 1 is not correct. Reference 2 and 3 are correct.

Many thanks again for your time and all your good work!!

I will just close my fork and propose an update with a new pull request soon.

Note that it's generally not necessary to close/delete a fork on GitHub. You can just follow the instructions at https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md#3b-submitting-changes-to-an-existing-style for updating your style.

Because in the corrections you made (line 517 removed) the <text variable="note" suffix=" "/> should be present. I managed to have the webpage date (if any) in the Extra field in addition to the website date.

@adam3smith, do we have a better variable for this? Maybe use the "container" date variable for the website with the expanded syntax, and "issued" for the webpage? (http://docs.citationstyles.org/en/1.0.1/specification.html#date-variables and https://www.zotero.org/support/kb/item_types_and_fields#citing_fields_from_extra)

Yes, I guess that makes sense, although I still don't quite understand the distinction between a webpage and a website date. What is a website date? Surely it can't be the date a website was first published (because -- who cares?). But if not that, I really have no idea.