Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new style for Forestry at TU Dresden #4051

Merged
merged 10 commits into from Apr 17, 2019
+452 −22

Conversation

Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jmiba @csl-bot @adam3smith
@jmiba
Copy link
Contributor

jmiba commented Apr 15, 2019

No description provided.

jmiba added some commits Apr 15, 2019

@jmiba
Merge pull request #2 from citation-style-language/master 
Update fork
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
93d0709
@jmiba
Add new style for Department of Forestry at TU Dresden
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ba106ce
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 15, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 15, 2019

😟 There are some issues with your submission. Please check the test report for details.
@jmiba
corrected template url
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
720b8fb
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 15, 2019

😃 Your submission passed all our automated tests.

jmiba added some commits Apr 15, 2019

@jmiba
Update technische-universitat-dresden-historische-musikwissenschaft-n… 
…ote.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e03aac1
@jmiba
Update technische-universitat-dresden-historische-musikwissenschaft-n… 
…ote.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bfa8563
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 15, 2019

😃 Your submission passed all our automated tests.
1 similar comment
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 15, 2019

😃 Your submission passed all our automated tests.
@jmiba
Update technische-universitat-dresden-historische-musikwissenschaft-n… 
…ote.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c55d171
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 15, 2019

😃 Your submission passed all our automated tests.
@jmiba
Update technische-universitat-dresden-forstwissenschaft.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7c2339b
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 15, 2019

😃 Your submission passed all our automated tests.
@jmiba

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jmiba commented Apr 15, 2019

This is also meant to be an update of another style
@adam3smith

adam3smith requested changes Apr 17, 2019
View changes

Copy link
Member

adam3smith left a comment

Thanks -- a couple of questions & change requests.
technische-universitat-dresden-forstwissenschaft.csl Outdated
<id>http://www.zotero.org/styles/technische-universitat-dresden-forstwissenschaft</id>
<link href="http://www.zotero.org/styles/technische-universitat-dresden-forstwissenschaft" rel="self"/>
<link href="http://www.zotero.org/styles/die-bachelorarbeit-samac-et-al-note" rel="template"/>
<link href="http://www.amazon.de/Bachelorarbeit-P%C3%A4dagogischen-Hochschule-wissenschaftlicher-Lehrerbildung/dp/3708901886" rel="documentation"/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Apr 17, 2019

Member

Could we get a link to documentation for this style? Ideally on the Lehrstuhl's homepage, but also OK to upload to this pull request and then put the link to the github comment in here.
technische-universitat-dresden-forstwissenschaft.csl Outdated
<name>Jens Mittelbach</name>
</author>
<category citation-format="author-date"/>
<category field="generic-base"/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Apr 17, 2019

Member

fix both the field (engineering might be best?) and the summary please (OK to just delete the summary if you have nothing to add beyond documentation)
technische-universitat-dresden-historische-musikwissenschaft-note.csl
</names>
<text macro="container-title" font-style="normal"/>
<text macro="secondary-container-contributors"/>
<group delimiter=", ">

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Apr 17, 2019

Member

I'm a bit confused -- this shouldn't change anything. Where is the comma intended to go?

This comment has been minimized.

Sign in to view
Copy link
@jmiba

jmiba Apr 17, 2019

Author Contributor

This is to take care of the problem of a double comma if a contianer author is present and no secondary container contributor(s) (as in author anthologies)

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Apr 17, 2019

Member

never mind, I misread the code. Makes sense.
technische-universitat-dresden-historische-musikwissenschaft-note.csl Outdated
@@ -464,7 +466,7 @@
<text macro="contributors-long"/>
<text macro="title-long"/>
<group>
<text macro="container"/>
<text macro="container" suffix=", "/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Apr 17, 2019

Member

Probably better as a delimiter in the group.

This comment has been minimized.

Sign in to view
Copy link
@jmiba

jmiba Apr 17, 2019

Author Contributor

You are right
technische-universitat-dresden-historische-musikwissenschaft-note.csl Outdated
@@ -502,7 +504,7 @@
<text macro="contributors-bib"/>
<text macro="title-long"/>
<group>
<text macro="container"/>
<text macro="container" suffix=", "/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Apr 17, 2019

Member

Probably better as a delimiter in the group.

This comment has been minimized.

Sign in to view
Copy link
@jmiba

jmiba Apr 17, 2019

Author Contributor

You are right
@jmiba
Added documenation as requested 
Uploaded file to pull request since it is not on the depatment's website
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d0d8864
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 17, 2019

😃 Your submission passed all our automated tests.
@jmiba
Corrected category and summary
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5987acd
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 17, 2019

😃 Your submission passed all our automated tests.
@jmiba
Change group element suffix to group delimiter as requested
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7cb5d71
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 17, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 0e41190 into citation-style-language:master Apr 17, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Apr 17, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.