Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always fetch latest sheldon #4143

Merged
merged 5 commits into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@retorquere
Copy link
Contributor

commented Jun 12, 2019

This always updates Sheldon before running the tests. This way, when Sheldon updates, only the Sheldon repo needs to be changed.

@csl-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

😟 There are some issues with your submission.

Please check the test report for details.

@retorquere retorquere changed the title always fetch latest sheldon [don't merge] always fetch latest sheldon Jun 12, 2019

@retorquere

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

I'm currently trying to figure out why bundle update sheldon fails on travis. It works locally.

@csl-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

😟 There are some issues with your submission.

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Ready to merge?

@csl-bot

This comment has been minimized.

Copy link

commented Jun 12, 2019

😃 Your submission passed all our automated tests.

@retorquere retorquere changed the title [don't merge] always fetch latest sheldon always fetch latest sheldon Jun 12, 2019

@retorquere

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

It is now, I just wanted to have one extra test run.

@rmzelle rmzelle merged commit a8cb679 into citation-style-language:master Jun 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.