New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issue templates #216

Merged
merged 2 commits into from May 2, 2018

Conversation

Projects
None yet
3 participants
@ruebot
Member

ruebot commented May 2, 2018

No description provided.

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot May 2, 2018

Member

Let me know if anything needs to be tweaked. If so, I'll update auk, and warclight.

Member

ruebot commented May 2, 2018

Let me know if anything needs to be tweaked. If so, I'll update auk, and warclight.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot May 2, 2018

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          34       34           
  Lines         665      665           
  Branches      124      124           
=======================================
  Hits          440      440           
  Misses        184      184           
  Partials       41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505c47a...48a44cc. Read the comment docs.

codecov bot commented May 2, 2018

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          34       34           
  Lines         665      665           
  Branches      124      124           
=======================================
  Hits          440      440           
  Misses        184      184           
  Partials       41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505c47a...48a44cc. Read the comment docs.

@ruebot ruebot requested review from ianmilligan1 and SamFritz May 2, 2018

@ianmilligan1

This looks fantastic. I just had a few minor suggestions which you can take or leave. 😄 Then I think it is ready to merge.

Show outdated Hide outdated .github/ISSUE_TEMPLATE/Bug_report.md
Show outdated Hide outdated .github/ISSUE_TEMPLATE/Bug_report.md
Show outdated Hide outdated .github/ISSUE_TEMPLATE/Bug_report.md
@SamFritz

This comment has been minimized.

Show comment
Hide comment
@SamFritz

SamFritz May 2, 2018

Member

Looks great @ruebot!

Just a quick question: what happens in the workflow if a user wants to request a feature (e.g. for AUK) but doesn't have GitHub account? I know we want to encourage everyone to fill out the template through Git, but just thinking about someone who may only be using AUK through the GUI.

(this may be a questions for down the line).

Member

SamFritz commented May 2, 2018

Looks great @ruebot!

Just a quick question: what happens in the workflow if a user wants to request a feature (e.g. for AUK) but doesn't have GitHub account? I know we want to encourage everyone to fill out the template through Git, but just thinking about someone who may only be using AUK through the GUI.

(this may be a questions for down the line).

@SamFritz

Looks great @ruebot! Examples given are very helpful!

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot May 2, 2018

Member

@SamFritz Slack or email? Then we could create an issue. Good question though.

Member

ruebot commented May 2, 2018

@SamFritz Slack or email? Then we could create an issue. Good question though.

@ianmilligan1

This comment has been minimized.

Show comment
Hide comment
@ianmilligan1

ianmilligan1 May 2, 2018

Member

Good point! If they click "new issue" w/o an account they'll get this.

screen shot 2018-05-02 at 3 16 54 pm

So maybe in places on the platform, etc. where we provide a link to "open an issue," we could also have an invitation to join our Slack group or e-mail us?

If that sounds good, we can merge this and keep this in mind for places where we invite people to open issues?

Member

ianmilligan1 commented May 2, 2018

Good point! If they click "new issue" w/o an account they'll get this.

screen shot 2018-05-02 at 3 16 54 pm

So maybe in places on the platform, etc. where we provide a link to "open an issue," we could also have an invitation to join our Slack group or e-mail us?

If that sounds good, we can merge this and keep this in mind for places where we invite people to open issues?

@SamFritz

This comment has been minimized.

Show comment
Hide comment
@SamFritz

SamFritz May 2, 2018

Member

I think email might be easier to manage (in terms of documenting specific cases/instances of features/bugs, Slack blends all conversations together). But I also realize that more and more people are on Slack. :)

Merge sounds good!

Member

SamFritz commented May 2, 2018

I think email might be easier to manage (in terms of documenting specific cases/instances of features/bugs, Slack blends all conversations together). But I also realize that more and more people are on Slack. :)

Merge sounds good!

@ianmilligan1 ianmilligan1 merged commit ef6ea36 into master May 2, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 505c47a...48a44cc
Details
codecov/project 66.16% remains the same compared to 505c47a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the issue-templates branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment