Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWashington Datathon Project - Issue 109 #110
Conversation
SamFritz
added some commits
Mar 27, 2019
SamFritz
self-assigned this
Mar 27, 2019
SamFritz
requested review from
ruebot and
ianmilligan1
Mar 27, 2019
ianmilligan1
requested changes
Mar 27, 2019
Some minor tweaks and then I think this is good to go. |
<ul> | ||
<li>Yoo Young Lee, University of Ottawa</li> | ||
<li>Christie Moffatt, National Library of Medicine</li> | ||
<li>Anna St.Onge, York University Libraries</li> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
content/washington/index.md
Outdated
<li>Grace Thomas, Library of Congress</li> | ||
<li>James Jacobs, Stanford University</li> | ||
<li>Laura Wrubel, George Washington University</li> | ||
<li>Olive Kiechle, Heinrich-Heine-University Duesseldorf</li> |
This comment has been minimized.
This comment has been minimized.
ianmilligan1
added this to In Progress
in GWU
via automation
Mar 27, 2019
ruebot
approved these changes
Mar 27, 2019
Just the Oliver fix, and I think we're good. @ianmilligan1 I'll leave it to you to merge and publish when the time comes if you'd like. |
ianmilligan1
approved these changes
Mar 28, 2019
ianmilligan1
merged commit 7816fe2
into
master
Mar 28, 2019
GWU
automation
moved this from In Progress
to Complete
Mar 28, 2019
ianmilligan1
deleted the
issue-109
branch
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SamFritz commentedMar 27, 2019
This PR addresses tasks listed in Issue 109
Template was used to display Washington projects to ensure responsive design.
Tasks addressed:
Testing:
Tested locally to make sure that images appear and links to pdf slides opens new tab.
Requested Reviewers:
@ianmilligan1 @ruebot this isn't an urgent ticket, but let me know if you see anything is missing. Would like to promote projects through newsletter and other channels later this week.