Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update applied-spectroscopy-reviews.csl #2652

Merged
merged 3 commits into from Apr 30, 2017

Conversation

Projects
None yet
4 participants
@gul916
Copy link
Contributor

commented Apr 26, 2017

enhance report and proceeding parts, based on damnation333 file

Update applied-spectroscopy-reviews.csl
enhance report and proceeding parts, based on damnation333 file
@csl-bot

This comment has been minimized.

Copy link

commented Apr 26, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Apr 26, 2017

😃 Your submission passed all our automated tests.

@POBrien333

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2017

Continuation of #2649 (comment)

Turn access into macro;
 more delimiters, less affixes
@csl-bot

This comment has been minimized.

Copy link

commented Apr 30, 2017

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 30, 2017

@gul916 @damnation333 made some tweaks for robustness & elegance. If either of you could take this for a spin before I merge?

@gul916

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2017

Hi @adam3smith ,
It seems fine for article, book, book chapter, proceeding, presentation, thesis, web, blog, forum, and report.

Minor corrections:
For manuscript, there are two spaces before "Available at".
For all accessed dates, is there a way to have only month and year without the day ?

@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 30, 2017

OK, the two spaces are fixed. Are you sure about omitting the day? It's such an odd requirement if you're going to include access dates and I wouldn't take specifics in the often hastily written instructions for authors too literally.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 30, 2017

😃 Your submission passed all our automated tests.

@gul916

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2017

@adam3smith
Ok, all is fine.
If it's an odd requirement, I will follow your advice and ignore it. Let's wait what the editor will say when I will submit my article.
Many thanks for your work.

@adam3smith adam3smith merged commit 111f980 into citation-style-language:master Apr 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 30, 2017

Thanks!

@gul916 gul916 deleted the gul916:patch-1 branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.