Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create estudios-de-cultura-maya.csl #2683

Merged
merged 7 commits into from May 24, 2017

Conversation

Projects
None yet
4 participants
@csl-bot

This comment has been minimized.

Copy link

commented May 11, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented May 11, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented May 11, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented May 11, 2017

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

left a comment

Looks good as best I can tell otherwise.

<text macro="archive"/>
</else-if>
</choose>
<text variable="DOI" prefix="doi:"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 12, 2017

Member

I'm not sure what exactly to do here since the style doesn't mention DOIs, but printing DOI and URL seems definitely wrong. Either don't do DOI at all, or use it -- converted to a URL -- in place of the URL.

<key variable="issued"/>
</sort>
<layout suffix=".">
<text macro="contributors" display="block"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 12, 2017

Member

The examples here: http://docs.citationstyles.org/en/stable/specification.html#display were intended exactly for this scenario. If you don't want to go that way, a tab seems a lot cleaner than multiple spaces after the year.

This comment has been minimized.

Copy link
@POBrien333

POBrien333 May 12, 2017

Author Contributor

Thanks. I even looked at the specs there and found the display="block" that I used, but I couldn't figure out from the documentation how I could get the space. Can you tell me how it works?

</group>
</layout>
</citation>
<bibliography hanging-indent="true" et-al-min="11" et-al-use-first="7" subsequent-author-substitute="———" entry-spacing="0">

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 12, 2017

Member

pretty sure the author-susbtitute should just be ""

<macro name="publisher">
<group delimiter=": ">
<text variable="publisher-place"/>
<text variable="publisher" suffix="."/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith May 12, 2017

Member

put suffix on group.

@csl-bot

This comment has been minimized.

Copy link

commented May 12, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented May 17, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented May 17, 2017

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

commented May 21, 2017

@damnation333 -- could you check if this makes sense & looks good to you?

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2017

@adam3smith
Awesome. Thanks for fixing this :) looks all good to me.

<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="note" version="1.0" demote-non-dropping-particle="sort-only" default-locale="es-MX">
<info>
<title>Estudios de Cultura Maya</title>

This comment has been minimized.

Copy link
@rmzelle

rmzelle May 24, 2017

Member

This should be <title>Estudios de Cultura Maya (Spanish - Mexico)</title> (add language descriptor to all styles fixed to non-English locales).

@csl-bot

This comment has been minimized.

Copy link

commented May 24, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented May 24, 2017

Looks good to me.

@rmzelle rmzelle merged commit 50815b3 into citation-style-language:master May 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented May 24, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.