Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate journal-of-clinical-neurophysiology.csl #2767
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 25, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 25, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 25, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 25, 2017
|
POBrien333
referenced this pull request
Jun 27, 2017
Merged
Create perspectives-on-sexual-and-reproductive-health.csl #2768
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 28, 2017
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 28, 2017
|
rmzelle
reviewed
Jun 28, 2017
<eissn>1537-1603</eissn> | ||
<issn>0736-0258</issn> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 28, 2017
Member
@damnation333, any reason you did this? I had already restarted the failing Travis build.
rmzelle
reviewed
Jun 28, 2017
<updated>2017-06-25T12:04:18+00:00</updated> | ||
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights> | ||
</info> | ||
<macro name="author"> | ||
<names variable="author" suffix=". "> | ||
<name et-al-min="19" et-al-use-first="19" initialize-with="" name-as-sort-order="all" sort-separator=" "/> | ||
<name et-al-min="7" et-al-use-first="3" initialize-with="" name-as-sort-order="all" sort-separator=" "/> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 28, 2017
Member
@adam3smith, I thought we had automatic checks against invalid et-al settings, but this didn't trigger any Travis errors. I'm not misremembering, right? Looks like I should investigate.
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 28, 2017
Member
I'm pretty sure you are misremembering this. We have talked about this, but I'm pretty sure we still have a pretty large number of styles with such settings.
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 28, 2017
Member
I'm pretty sure you are misremembering this. We have talked about this, but I'm pretty sure we still have a pretty large number of styles with such settings.
See #2207.
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 28, 2017
Member
ah sorry, you're right, I was wrong -- but the test checks for "greater or equal" when it should check for "greater", right?
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 28, 2017
Member
Ah, yes, good catch! (we should fix this in a PR so we can fix any problematic styles before Travis starts to complain; I'll put it on my todo list)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 28, 2017
|
rmzelle
merged commit 5fd3b92
into
citation-style-language:master
Jun 29, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
@damnation333, thanks! (you seemed a little sloppy on the et-al settings, though |
This comment has been minimized.
This comment has been minimized.
Yup. Sorry about that. I do indeed need to be careful. I've been pushing these out like a machine lately. Thanks for looking over them. |
This comment has been minimized.
This comment has been minimized.
Just so you know, I usually only look carefully at the style metadata (title, documention link, ISSNs, etc.) and take a very brief look at the style code. I don't have the time to actually test and check the output of styles, so we rely mostly on you for that.
No, first |
POBrien333 commentedJun 25, 2017
•
edited by rmzelle
via https://forums.zotero.org/discussion/comment/229467#Comment_229467
(based on a style ready under review (#2766), hence it's not validating yet)