Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove edition macro for din-1505-2 #3559
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 20, 2018
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
Yes, this is definitely better; we do this routinely in other styles. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 20, 2018
|
This comment has been minimized.
This comment has been minimized.
I just realized that - if this is considered an improvement - I should apply the same modifications to din-1505-2-alphanumeric.csl, din-1505-2-numeric-alphabetical.csl and din-1505-2-numeric.csl |
heikojansen
added some commits
Jun 20, 2018
This comment has been minimized.
This comment has been minimized.
Done |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 20, 2018
|
2 similar comments
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 20, 2018
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 20, 2018
|
rmzelle
merged commit f560249
into
citation-style-language:master
Jun 23, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
heikojansen commentedJun 20, 2018
Almost any edition i encountered is either plain numeric or - if not - already contains some (abbreviated) form of the word "edition". So in most cases my German citations have edition statements ending in "... Aufl. Aufl.", with the latter occurrence provided by the element in the style.
Unfortunately, I have no statistical data to prove that this solution is better.
But at least the modifications in this patch request are based on how the "edition" is formatted in vancouver.csl.