Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate bulletin-of-the-seismological-society-of-america.csl #3647
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Aug 14, 2018
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Aug 14, 2018
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Aug 14, 2018
|
adam3smith
requested changes
Aug 14, 2018
One nit, one question. Thanks! |
</if> | ||
</choose> | ||
</macro> | ||
<macro name="mapinfo"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 14, 2018
Member
Is this from the template style? Can we do better here? I really don't like using note
in styles.
This comment has been minimized.
This comment has been minimized.
POBrien333
Aug 14, 2018
Author
Contributor
Sure. Guidelines not stating anything, but I guess this could be useful for seismologists.
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 14, 2018
Member
what info is in there, though? We do, e.g., have "scale" for maps in Zotero&CSL?
</macro> | ||
<macro name="accessed"> | ||
<choose> | ||
<if type="webpage post-weblog"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 14, 2018
Member
needs match="any"
(otherwise defaults to match="all"
even though Zotero/citeproc-js may not implement that correctly.
This comment has been minimized.
This comment has been minimized.
POBrien333
Aug 14, 2018
Author
Contributor
I wonder how that would've happened. I did this in the visual editor like always (click on plus and add post-weblog). thanks for spotting.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Aug 14, 2018
|
rmzelle
merged commit 1fa453d
into
citation-style-language:master
Aug 14, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
POBrien333 commentedAug 14, 2018
•
edited by rmzelle
via https://forums.zotero.org/discussion/73051/style-request-bulletin-of-seismological-society-of-america