Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create aci-materials.csl #3690

Merged
merged 4 commits into from Sep 15, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@POBrien333 @csl-bot @rmzelle
@POBrien333
@POBrien333
Create aci-materials.csl 
https://forums.zotero.org/discussion/73577/style-request-aci-structural-journal#latest
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
83a64b4
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 14, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 14, 2018

😟 There are some issues with your submission. Please check the test report for details.
@POBrien333
Update aci-materials.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6d4d37b
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 14, 2018

😟 There are some issues with your submission. Please check the test report for details.
@POBrien333
Update aci-materials.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f8789eb
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 14, 2018

😃 Your submission passed all our automated tests.
@rmzelle
Update and rename aci-materials.csl to aci-materials-journal.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aed9c49
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 15, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 0a67c3b into citation-style-language:master Sep 15, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 15, 2018

@POBrien333, thanks! The ISSNs you used seemed to be for the sister journal "ACI Structural Journal" (see https://www.ncbi.nlm.nih.gov/nlmcatalog?term=0889-3241%5BISSN%5D and https://www.ncbi.nlm.nih.gov/nlmcatalog?term=0889-325X%5BISSN%5D). Also the "Journal" seems to be part of the title. Otherwise good! ;)

@POBrien333 POBrien333 deleted the POBrien333:patch-394 branch Sep 15, 2018

POBrien333 added a commit to POBrien333/styles that referenced this pull request Oct 11, 2018

@POBrien333
Create aci-structural-journal.csl 
In addition to parent style from citation-style-language#3690, here is a dependent style for the sister journal which follows the same style.
Checked based on sample publication: https://www.researchgate.net/publication/231520218_ACI_STRUCTURAL_JOURNAL_TECHNICAL_PAPER
Guidelines for this journal link right back to aci-materials-journals
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3419a1a

POBrien333 added a commit to POBrien333/styles that referenced this pull request Oct 11, 2018

@POBrien333
Create aci-structural-journal.c 
In addition to parent style from citation-style-language#3690, here is a dependent style for the sister journal which follows the same style.
Checked based on sample publication: https://www.researchgate.net/publication/231520218_ACI_STRUCTURAL_JOURNAL_TECHNICAL_PAPER
Guidelines for this journal link right back to aci-materials-journals
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
efe71cc

@POBrien333 POBrien333 referenced this pull request Oct 11, 2018

Merged

Create aci-structural-journal.csl #3739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.