Skip to content

/auk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup wasapi_files_helper_test #87

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
@ruebot
Copy link
Member

commented Mar 28, 2018

  • Add test
  • Update test fixtures for collections, and wasapi_files
  • Add codecov config

Let's see how this does.
@ruebot
Setup wasapi_files_helper_test 
- Add test
- Update test fixtures for collections, and wasapi_files
- Add codecov config
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
8d92acd
@codecov

This comment has been minimized.

Sign in to view
Copy link

commented Mar 28, 2018 •
edited

Codecov Report

Merging #87 into master will increase coverage by 2.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   81.27%   83.47%   +2.19%     
==========================================
  Files          24       25       +1     
  Lines         219      230      +11     
==========================================
+ Hits          178      192      +14     
+ Misses         41       38       -3
Impacted Files Coverage Δ
test/helpers/wasapi_files_helper_test.rb 100% <100%> (ø)
app/helpers/wasapi_files_helper.rb 53.84% <0%> (+23.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71fa23c...8d92acd. Read the comment docs.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 28, 2018

@ianmilligan1 can you merge this when you get a chance?

@ruebot ruebot referenced this pull request Mar 28, 2018

Merged

Gravatar test #88

@ianmilligan1

ianmilligan1 approved these changes Mar 28, 2018
View changes

@ianmilligan1 ianmilligan1 merged commit d2b775a into archivesunleashed:master Mar 28, 2018
3 checks passed

3 checks passed

codecov/patch 100% of diff hit (target 81.27%)
Details
codecov/project 83.47% (+2.19%) compared to 71fa23c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the ruebot:wasapi-files-helper-test branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.