Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.68.1 #68

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@depfu
Copy link
Contributor

commented May 1, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.67.2 → ~> 0.68.1) · Repo · Changelog

Release Notes

0.68.1

Bug fixes

  • #6993: Allowing for empty if blocks, preventing Style/SafeNavigation from crashing. (@RicardoTrindade)
  • #6995: Fix an incorrect auto-correct for Style/RedundantParentheses when enclosed in parentheses at while-post or until-post. (@koic)
  • #6996: Fix a false positive for Style/RedundantFreeze when freezing the result of String#*. (@bquorning)
  • #6998: Fix autocorrect of Naming/RescuedExceptionsVariableName to also rename all references to the variable. (@Darhazer)
  • #6992: Fix unknown default configuration for Layout/IndentFirstParameter cop. (@drenmi)
  • #6972: Fix a false positive for Style/MixinUsage when using inside block and if condition is after include. (@koic)
  • #6738: Prevent auto-correct conflict of Style/Next and Style/SafeNavigation. (@hoshinotsuyoshi)
  • #6847: Fix Style/BlockDelimiters to properly check if the node is chaned when braces_for_chaining is set. (@att14)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 15 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #68   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003a194...9cb36a3. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #68   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003a194...9cb36a3. Read the comment docs.

@ruebot

ruebot approved these changes May 2, 2019

@ruebot ruebot merged commit 2fa3c21 into master May 2, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 003a194...9cb36a3
Details
codecov/project 100% remains the same compared to 003a194
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/rubocop-0.68.1 branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.