Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upBetter Highlights Need for Archive-It Credentials, Resolves #293 #295
+7
−0
Conversation
ianmilligan1
added some commits
May 9, 2019
ianmilligan1
requested review from
ruebot and
SamFritz
May 9, 2019
ruebot
approved these changes
May 9, 2019
app/views/pages/home.html.erb
Outdated
| @@ -1,4 +1,10 @@ | |||
| <% cache do %> | |||
| <div class="alert alert-warning alert-dismissible fade show" role="alert"> | |||
| <strong>New user?</strong> You currently need Archive-It credentials to use our service. Please read our <%= link_to('FAQ', '/faq', target: '_blank') %>. | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
May 9, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 35 35
Lines 619 619
=======================================
Hits 553 553
Misses 66 66Continue to review full report at Codecov.
|
SamFritz
approved these changes
May 9, 2019
ruebot
merged commit b4f5758
into
master
May 9, 2019
ruebot
deleted the
issue-293
branch
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedMay 9, 2019
GitHub issue(s):
#293
What does this Pull Request do?
In #293, we noted that we needed to highlight the need for an Archive-It account to use the Cloud. While that may change down the road, right now we have a lot of folks who sign up for the Cloud but then realize they need an Archive-It account and are a bit confused or disappointed.
This PR does two main things:
How should this be tested?
TravisCI should turn green. Please review for language suggestions and aesthetic appeal.
Screenshots:
Screenshots added for convenience.
Here's the new home page:
And here's the added content to the "about" page (red arrow is my screenshot annotation):
Interested parties
@ruebot @SamFritz