Skip to content

/auk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] [ruby] Update chartkick: 3.1.0 → 3.2.0 (minor) #305

Merged
merged 1 commit into from Jun 5, 2019
+1 −1

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
2 participants
@codecov-io @ruebot
@depfu
Copy link
Contributor

commented Jun 5, 2019

🚨 Your version of chartkick has known security vulnerabilities 🚨

Advisory: CVE-2019-12732
Disclosed: June 04, 2019
URL: https://github.com/ankane/chartkick/issues/488

XSS Vulnerability in Chartkick Ruby Gem

Chartkick is vulnerable to a cross-site scripting (XSS) attack if
both the following conditions are met:

Condition 1:
It's used with ActiveSupport.escape_html_entities_in_json = false
(this is not the default for Rails)
OR used with a non-Rails framework like Sinatra.

Condition 2:
Untrusted data or options are passed to a chart.

<%= line_chart params[:data], min: params[:min] %>


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ chartkick (3.1.0 → 3.2.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 4 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 5, 2019

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Jun 5, 2019

Codecov Report

Merging #305 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   89.33%   89.33%           
=======================================
  Files          35       35           
  Lines         619      619           
=======================================
  Hits          553      553           
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7e4c5...a39c8ab. Read the comment docs.

@ruebot ruebot merged commit 522d5fa into master Jun 5, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing 7d7e4c5...a39c8ab
Details
codecov/project 89.33% remains the same compared to 7d7e4c5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/chartkick-3.2.0 branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.