Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Royal Society of Chemistry bold journal title #4182

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@TobiasVoepel
Copy link

commented Jul 8, 2019

This is the RSC style which has added bold journal titles

Create Royal Society of Chemistry bold journal title
This is the RSC style which has added bold journal titles
@csl-bot

This comment has been minimized.

Copy link

commented Jul 8, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 8, 2019

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/Royal Society of Chemistry bold journal title"]

(compared using ==)

Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thanks -- before you try to fix the automated tests, could you specify what this is for? I don't think RSC prints journal titles in bold, does it?

@TobiasVoepel

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

OK, makes sense. I'm trying to figure out if this is a good fit to host on the repository or if it would make sense for you to just host locally. Who would be using/downloading this style? Members of a particular working group? Department? The whole university? Students or just researchers? Or are these generated using an API/online service.

In general, the fewer people a style is aimed at, the less suitable for centralized hosting here it is.

@TobiasVoepel

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

OK -- we generally don't host styles for usage in APIs. The styles here are made available to end-users via Zotero, Mendeley, etc. and there is no reason to have this style included in that list. Any reason you couldn't just host this internally? An API shouldn't care where the style is hosted.

@TobiasVoepel

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.