New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic DataFrame documentation, resolves #61 #62

Merged
merged 3 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@ianmilligan1
Member

ianmilligan1 commented Oct 16, 2018

This adds basic DataFrame documentation for

  • domain extraction;
  • hyperlink extraction;
  • image analysis.

I don't think I missed any, but it is possible. I noted the experimental nature of the code. But this is really useful for both potential users who are curious about DataFrames as well as us when trying to remember how to use all this.

@ianmilligan1 ianmilligan1 requested review from ruebot and lintool Oct 16, 2018

You may want to see the schema that you can use when working with domains. To do so, run the following script:
```scala

This comment has been minimized.

@lintool

lintool Oct 16, 2018

Member

might want to move the schema description up - i.e., here's the schema... and then, here's what you can do...

same below.

@lintool

lintool Oct 16, 2018

Member

might want to move the schema description up - i.e., here's the schema... and then, here's what you can do...

same below.

This comment has been minimized.

@ianmilligan1
@ianmilligan1

ianmilligan1 Oct 16, 2018

Member

👍

@lintool

minor comments, but otherwise lgtm.

@ruebot

ruebot approved these changes Oct 16, 2018

One little change, and good to go.

@ruebot ruebot merged commit 216b7c3 into master Oct 16, 2018

@ruebot ruebot deleted the dataframes branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment