Skip to content

/auk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] [ruby] Update nokogiri: 1.10.2 → 1.10.3 (patch) #289

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Reviewers

@ruebot ruebot

Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
2 participants
@codecov-io @ruebot
@depfu
Copy link
Contributor

depfu bot commented Apr 22, 2019

🚨 Your version of nokogiri has known security vulnerabilities 🚨

Advisory: CVE-2019-11068
Disclosed: April 22, 2019
URL: https://github.com/sparklemotion/nokogiri/issues/1892

Nokogiri gem, via libxslt, is affected by improper access control vulnerability

Nokogiri v1.10.3 has been released.

This is a security release. It addresses a CVE in upstream libxslt rated as
"Priority: medium" by Canonical, and "NVD Severity: high" by Debian. More
details are available below.

If you're using your distro's system libraries, rather than Nokogiri's
vendored libraries, there's no security need to upgrade at this time, though
you may want to check with your distro whether they've patched this
(Canonical has patched Ubuntu packages). Note that this patch is not yet (as
of 2019-04-22) in an upstream release of libxslt.

Full details about the security update are available in Github Issue
[#1892] #1892.

CVE-2019-11068

Permalinks are:

Description:

libxslt through 1.1.33 allows bypass of a protection mechanism
because callers of xsltCheckRead and xsltCheckWrite permit access
even upon receiving a -1 error code. xsltCheckRead can return -1 for
a crafted URL that is not actually invalid and is subsequently
loaded.

Canonical rates this as "Priority: Medium".

Debian rates this as "NVD Severity: High (attack range: remote)".


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ nokogiri (indirect, 1.10.2 → 1.10.3) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 5 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Apr 22, 2019

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Apr 22, 2019 •
edited

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          35       35           
  Lines         557      557           
=======================================
  Hits          536      536           
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5e408...2f1dc3e. Read the comment docs.
@ruebot

ruebot approved these changes Apr 22, 2019
View changes

@ruebot ruebot merged commit d607152 into master Apr 22, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing ce5e408...2f1dc3e
Details
codecov/project 96.22% remains the same compared to ce5e408
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/nokogiri-1.10.3 branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.