Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesRequests futures for image download #153
+254
−240
Conversation
shawnmjones
added some commits
Jun 13, 2019
shawnmjones
self-assigned this
Jun 13, 2019
shawnmjones
merged commit 6d5823b
into
master
Jun 13, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
shawnmjones
deleted the
requests-futures-for-image-download
branch
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
shawnmjones commentedJun 13, 2019
•
edited
Running image downloads in parallel with the requests_futures library should speed up image selection. MementoEmbed no longer just considers the first 15 images. Now it has time to look at all images on the page.