Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesadding whedon generate pdf example to pre-review issue #556
Conversation
This comment has been minimized.
This comment has been minimized.
|
Good idea. Unfortunately this is in the wrong place - the edits you've made here are to some fixtures for the tests. I've added this language over in openjournals/whedon-api@6611b88 |
arfon
closed this
Jul 11, 2019
arfon
deleted the
danielskatz-patch-1
branch
Jul 11, 2019
This comment has been minimized.
This comment has been minimized.
|
thanks - the source tree is extremely confusing to me, so I just grep for what I want to change and then change it - maybe I should have paid more attention to multiple results :) |
This comment has been minimized.
This comment has been minimized.
Totally reasonable strategy :-) |
This comment has been minimized.
This comment has been minimized.
|
although in this case, where the change I needed to make was in a different repo, I don't think I could have been successful |
danielskatz commentedJul 8, 2019
No description provided.