Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRename controlled access terms default configuration: Issue 1132 #112
Conversation
seth-shaw-unlv
added some commits
May 29, 2019
This was referenced May 29, 2019
This comment has been minimized.
This comment has been minimized.
|
@seth-shaw-unlv Works just fine. |
dannylamb
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
|
@dannylamb you can now merge Islandora-CLAW/islandora_defaults/pull/1 and this one. |
dannylamb
merged commit c96adef
into
Islandora-Devops:master
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
seth-shaw-unlv commentedMay 29, 2019
•
edited
GitHub Issue: Islandora-CLAW/CLAW/issues/1132
What does this Pull Request do?
Replaces 'controlled_access_terms_default_configuration' with 'controlled_access_terms_defaults'.
What's new?
How should this be tested?
vagrant upAdditional Notes:
Once this is tested and both Islandora-CLAW/controlled_access_terms/pull/29 and Islandora-CLAW/islandora_defaults/pull/1 are merged we need to revert the
islandora/islandora_defaults:dev-issue-1132in drupal.yml back toislandora/islandora_defaults:dev-8.x-1.xbefore merging.Interested parties
@dannylamb, @Islandora-CLAW/committers