Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for defining php variables for external role. #59
Conversation
This comment has been minimized.
This comment has been minimized.
I think this is the way to go. We could do it in vars + bootstrap.yml, but since geerlingguy's role already provides the logic this seems the better solution. |
This comment has been minimized.
This comment has been minimized.
I agree with @seth-shaw-unlv this solution work fine and follow a geerlingguy role-php. |
This comment has been minimized.
This comment has been minimized.
Oddly enough, I just discovered that this doesn't actually work. Ansible doesn't complain and a CentOS provision works, but when I spun up a Debian-based Islandora the apache php library wasn't there. I removed the Debian.yml file altogether and it actually worked then. To be honest, I'm not sure what is going on with the Debian php_packages_extra here. |
This comment has been minimized.
This comment has been minimized.
Alright we can't hack geerlingguy's role, so we need to store these variables using a separate named variable file and include based on ansible_os_family at the start of the bootstrapping. I'm closing this. |
whikloj
closed this
Feb 20, 2018
whikloj
reopened this
Feb 23, 2018
This comment has been minimized.
This comment has been minimized.
Can someone try this out. It seems to work, but then I thought the last attempt worked too |
This comment has been minimized.
This comment has been minimized.
@whikloj for some reason geerligguy.php role didn't saw /var/RedHat.yml... (in my case) |
This comment has been minimized.
This comment has been minimized.
May not be related this PR! |
This comment has been minimized.
This comment has been minimized.
@DigitLib / @Natkeeran thanks...I'll try burning my setup down and pulling fresh to see what is happening. |
This comment has been minimized.
This comment has been minimized.
@whikloj this /var files seem to work today. I try it on Manjaro Linux, yesterday it won't on Fedora 26... Tried Ubuntu and CentOS it works on both. Without added gather_facts: false... |
This comment has been minimized.
This comment has been minimized.
Thanks @DigitLib / @Natkeeran, I am getting an error but not until building the Grok dependencies. That was on Centos, I'll tear it down and try again with Ubuntu |
This comment has been minimized.
This comment has been minimized.
@whikloj You can ignore the previous error I posted. I may not have installed the requirements! (was sleeping!). This PR installs without error, but get the same php error related to missing library: |
This comment has been minimized.
This comment has been minimized.
@Natkeeran @mjordan @DigitLib Moving it into the tasks and using We could also use more specific files if necessary and the
|
This comment has been minimized.
This comment has been minimized.
Tested both Ubuntu and CentOS today. Both work for me now. |
whikloj commentedFeb 15, 2018
Hopefully resolves Islandora-CLAW/CLAW#801
To define the variables for use in geerlingguy.php to use different versions of
php_packages_extra
this seems to work as his role includes these file names.Perhaps the better way is to move this stuff to a
/vars
directory, but then I don't know how you set a variable in the inventory. Would we do that in thebootstrap.yml
?If there is a better way, please tell me. But this seems to work.
Interested parties
@seth-shaw-unlv @DigitLib @Natkeeran @MarcusBarnes @jonathangreen