Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up7.x solr thumbnail #663
Conversation
MorganDawe
added some commits
Dec 12, 2016
adam-vessey
requested changes
Dec 14, 2016
adam-vessey left a comment
|
Just a typo in the comment; otherwise, looks good and worked. |
| * does not exceed that of its parent container (ex: 20%). | ||
| * | ||
| * img styling (max-height) - Avoid making assumptions on max height here, allowing auto | ||
| * height based on max-width of 100%. Consider overrideing this file in your theme, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adam-vessey
approved these changes
Dec 14, 2016
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
DiegoPino
commented
Jan 10, 2017
|
@MorganDawe just quick, because I don't see any harm to make max with 100% (means I'm ok): does this addresses the note about unifying the CSS approach? or is this a temporary solution? I see that specific CSS islandora-object class not being used that broadly, so how this affects/fixes the problem? |
This comment has been minimized.
This comment has been minimized.
dannylamb
commented
Jan 10, 2017
|
@DiegoPino If you would like to see a unified approach, feel free to make a ticket in JIRA and we'll address it. |
dannylamb
merged commit 3452767
into
Islandora:7.x
Jan 10, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
DiegoPino
commented
Jan 10, 2017
|
@dannylamb thanks for your suggestion. The unified approach was discussed in the comitters call as the way to go as noted here https://jira.duraspace.org/browse/ISLANDORA-1870?focusedCommentId=53300&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-53300 |
MorganDawe commentedDec 12, 2016
JIRA Ticket: (https://jira.duraspace.org/browse/ISLANDORA-1870)
What does this Pull Request do?
Basic fix for SPARQL and SOLR thumbnail display width.
What's new?
Add a max-width to thumbnails using the SOLR Backend display
Example:
How should this be tested?
Note
Related in part to this ticket: https://jira.duraspace.org/browse/ISLANDORA-1609, i believe the ultimate solution is to ensure both displays are run thru the same preprocess functions, using the same HTML and CSS as each other. However, that may be to dramatic of a change outside of a major release.
Interested parties
Tag @Islandora/7-x-1-x-committers