Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds Jupyter Notebooks to Website, resolves #115 #116
Conversation
ianmilligan1
requested review from
greebie,
ruebot and
SamFritz
Apr 17, 2019
ruebot
approved these changes
Apr 18, 2019
greebie
reviewed
Apr 18, 2019
content/notebooks/index.md
Outdated
|
|
||
|  | ||
|
|
||
| Domains are a fairly basic analysis of the web archive, and while important, there’s not too much to do, other than to highlight what domains are included in the web archive and how often they appear. |
This comment has been minimized.
This comment has been minimized.
greebie
Apr 18, 2019
Collaborator
Maybe leave out the "there's not too much to do" since that may make them think there's no point in taking a look. I mean there is a little bit of data munging and playing with the .com, .org etc.
"... web archive that highlight what domains are included and how often they appear. You can, for example, see how many .com addresses are in the collection."
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Apr 18, 2019
Author
Member
Great, thanks @greebie! How would
Domains are a fairly basic analysis of the web archive that highlight what domains are included and how often they appear. You can, for example, see how many .com addresses are in the collection or which domains are over or underrepresented.
Look to you?
This comment has been minimized.
This comment has been minimized.
greebie
Apr 18, 2019
Collaborator
Looks good. And I learned that under-represented and underrepresented are both acceptable spellings!
SamFritz
merged commit 9711e5c
into
master
Apr 18, 2019
ianmilligan1
deleted the
Issue-115
branch
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedApr 17, 2019
This pull request adds a new page on the Archives Unleashed Cloud Jupyter Notebooks, accessible from the main page as well as from the menu bar.
Thoughts, suggestions, changes, etc. all greatly appreciated.