Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Spark Job with new WriteGraph; Resolves #211 #212
+2
−2
Conversation
ianmilligan1
added some commits
Nov 28, 2018
ianmilligan1
requested a review
from ruebot
Nov 28, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Nov 28, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
======================================
Coverage 89.4% 89.4%
======================================
Files 35 35
Lines 623 623
======================================
Hits 557 557
Misses 66 66Continue to review full report at Codecov.
|
ruebot
added
the
on hold
label
Dec 11, 2018
ruebot
added some commits
Aug 26, 2019
ruebot
approved these changes
Aug 26, 2019
ruebot
merged commit a10db14
into
master
Aug 26, 2019
ruebot
deleted the
issue-211
branch
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedNov 28, 2018
This should not be merged until AUT 0.18 is released with the new
WriteGraphfunctionalityGitHub issue(s):
#211
What does this Pull Request do?
This is a relatively straight-forward pull request that changes the syntax in the Spark Job from the older
WriteGraphMLto the newerWriteGraph.asGraphml. This has the primary effect of turning node IDs for the networks from long hashes to simple numbers.It also updates the
application.yml.exampleas if users are using a version before 0.18.0 the command won't work.I figured this should be done on a branch as I wanted to particularly make sure that the ensuing networks work well in Gephi. They appear to do so.
How should this be tested?
I have tested locally but basically we will want to see that (a) the standard suite of derivatives are generated; and (b) the ensuing network files work. The two screenshots show some local testing, showing how the new graphs render well after GraphPass and also work well in Gephi.
Additional Notes:
As noted above, only merge once new AUT is released. This should not require new documentation.
Interested parties
@ruebot @greebie