Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for full_text in tweets; resolve #192. #252
Conversation
ianmilligan1
approved these changes
Aug 10, 2018
Tested and works very well. Can merge once the lights turn green.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
bot
Aug 10, 2018
Codecov Report
Merging #252 into master will increase coverage by
0.02%
.
The diff coverage is100%
.
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 70.11% 70.14% +0.02%
==========================================
Files 41 41
Lines 1024 1025 +1
Branches 191 191
==========================================
+ Hits 718 719 +1
Misses 240 240
Partials 66 66
Impacted Files | Coverage Δ | |
---|---|---|
...n/scala/io/archivesunleashed/util/TweetUtils.scala | 92.3% <100%> (+0.64%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a5fa151...a4aba17. Read the comment docs.
codecov
bot
commented
Aug 10, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 70.11% 70.14% +0.02%
==========================================
Files 41 41
Lines 1024 1025 +1
Branches 191 191
==========================================
+ Hits 718 719 +1
Misses 240 240
Partials 66 66
Continue to review full report at Codecov.
|
ruebot commentedAug 10, 2018
GitHub issue(s):
#192
What does this Pull Request do?
Add support to the Tweet utility to use
full_text
from tweets.How should this be tested?
I did this with Apache Spark 2.3.1:
If you want to use the same tweet set, it's here.
Additional Notes:
Once this is good to go, I'll take care of #194.
Interested parties
@ianmilligan1 @lintool