Skip to content

/aut

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Java 8 & 11, and remove OracleJDK; resolves #324. #325

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @codecov-io @ianmilligan1
@ruebot
Copy link
Member

commented Jul 8, 2019

See: #324

@ruebot ruebot requested a review from ianmilligan1 Jul 8, 2019

@ruebot ruebot force-pushed the java-11-test branch 2 times, most recently from 870c568 to 16602d0 Jul 8, 2019

@ruebot ruebot changed the title Test Java 9, 10, 11; resolves #324. Test Java 8 & 11, and remove OracleJDK; resolves #324. Jul 8, 2019

@ruebot ruebot force-pushed the java-11-test branch 2 times, most recently from d072b23 to c507991 Jul 8, 2019

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Jul 8, 2019 •
edited

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   75.95%   75.95%           
=======================================
  Files          41       41           
  Lines        1148     1148           
  Branches      200      200           
=======================================
  Hits          872      872           
  Misses        209      209           
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a61f0e...04396c9. Read the comment docs.
@ruebot
Test Java 8 & 11, and remove OracleJDK; resolves #324.
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
04396c9

@ruebot ruebot force-pushed the java-11-test branch from c507991 to 04396c9 Jul 8, 2019

@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 8, 2019

@ianmilligan1 this is good to go now. Apologies for all the activity on what should have been a simple task 😅
@ianmilligan1

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 8, 2019

@ruebot Hah sounds good. Just building it locally right now and then can review + merge. A bit slow as eduroam isn't playing nice so my phone is doing the lifting this afternoon.
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 8, 2019

@ianmilligan1 it's just a TravisCI config on this one. So, TravisCI is all you really need here.
@ianmilligan1

ianmilligan1 approved these changes Jul 8, 2019
View changes

Copy link
Member

left a comment

TravisCI turns green!

@ianmilligan1 ianmilligan1 merged commit 4ce59c8 into master Jul 8, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing 7a61f0e...04396c9
Details
codecov/project 75.95% remains the same compared to 7a61f0e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the java-11-test branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.