Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesUpdates to pom following 0e701b271e04e60c6fa89f39299dae7142d700b8 #328
+5
−10
Conversation
ruebot
requested a review
from ianmilligan1
Jul 23, 2019
ianmilligan1
approved these changes
Jul 23, 2019
|
Tested locally and all checks out. Once TravisCI turns green I'll merge! |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jul 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 74.97% 74.97%
=======================================
Files 39 39
Lines 1123 1123
Branches 197 197
=======================================
Hits 842 842
Misses 215 215
Partials 66 66Continue to review full report at Codecov.
|
ianmilligan1
merged commit 19b49e1
into
master
Jul 23, 2019
ianmilligan1
deleted the
more-clean-up
branch
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedJul 23, 2019
What does this Pull Request do?
0e701b2)
The updates are mostly to get
autback to a place where we don't have mixed Scala version warnings. However, as I dug deeper into getting everything up to 2.11.12 we ran into lots of problems. This gets us part of the way there, and we can come back later should we want to.How should this be tested?