Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage. #354

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@ruebot
Copy link
Member

commented Aug 22, 2019

GitHub issue(s): none

What does this Pull Request do?

  • Add tests a few more filters in RecordLoader
  • Add binary extraction DataFrameLoader tests

How should this be tested?

  • TravisCI
Improve test coverage.
- Add tests a few more filters in RecordLoader
- Add binary extration DataFrameLoader tests
@codecov

This comment has been minimized.

Copy link

commented Aug 22, 2019

Codecov Report

Merging #354 into master will increase coverage by 1.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   74.76%   75.91%   +1.15%     
==========================================
  Files          39       39              
  Lines        1387     1387              
  Branches      265      265              
==========================================
+ Hits         1037     1053      +16     
+ Misses        234      218      -16     
  Partials      116      116
@greebie

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Inching to 80%! Awesome to see!

@ianmilligan1
Copy link
Member

left a comment

Looks great!

@ianmilligan1 ianmilligan1 merged commit bced854 into master Aug 22, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 4313174...f8a3aef
Details
codecov/project 75.91% (+1.15%) compared to 4313174
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the package-tests branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.