Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ExtractPopularImages, WriteGEXF, and WriteGraphML to Python. #466
+59
−31
Conversation
| from pyspark.sql.functions import desc, first | ||
|
|
||
|
|
||
| def Extract_Popular_Images(d: DataFrame, limit: int, min_width: int, min_height: int): |
This comment has been minimized.
This comment has been minimized.
ruebot
May 25, 2020
Author
Member
Oh, I don't need to do the type hinting here. I'll yank this before we merge in the end.
codecov
bot
commented
May 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 49 49
Lines 1442 1442
Branches 279 279
=======================================
Hits 1094 1094
Misses 218 218
Partials 130 130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ruebot commentedMay 25, 2020
•
edited
GitHub issue(s): #409
What does this Pull Request do?
Add ExtractPopularImages, WriteGEXF, and WriteGraphML to Python.
How should this be tested?