Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helvetica-chimica-acta #4168

Merged
merged 4 commits into from Jul 15, 2019
+181 −0

Conversation

Reviewers

@rmzelle rmzelle

@adam3smith adam3smith

@POBrien333 POBrien333

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@daenuprobst @csl-bot @adam3smith @rmzelle @POBrien333
@daenuprobst
Copy link
Contributor

commented Jul 3, 2019

Was not yet available.
@daenuprobst
Create helvetica-chimica-acta
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8cad22e
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 3, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 3, 2019

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain extra files (make sure styles have a ".csl" extension)

expected: []
     got: ["/home/travis/build/citation-style-language/styles/helvetica-chimica-acta"]

(compared using ==)

Please check the test report for details.
@POBrien333

POBrien333 reviewed Jul 4, 2019
View changes

helvetica-chimica-acta Outdated
<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" demote-non-dropping-particle="sort-only" default-locale="en-US">
<info>
<title>Helvetica Chimica Acta</title>
<id>http://www.zotero.org/styles/angewandte-chemie</id>

This comment has been minimized.

Sign in to view
Copy link
@POBrien333

POBrien333 Jul 4, 2019

Contributor
  1. change this line to match with your self link.
  2. And I guess angewande-chemie was your template style. Please add that below the self link with rel="template".
  3. add the .csl extension to your filename.
@rmzelle
Update and rename helvetica-chimica-acta to helvetica-chimica-acta.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e076265
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 7, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

helvetica-chimica-acta.csl (new)
[1,2]
[3,4]
[1]B. Hancké, M. Rhodes, M. Thatcher, Eds. , Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy, Oxford University Press, Oxford and New York, 2007.
[2]“CSL search by example,” can be found under http://editor.citationstyles.org/searchByExample/, 2012.
[3]I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (Eds.: P.A. Hall, D. Soskice), Oxford University Press, New York, 2001, pp. 184–213.
[4]M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, et al., ‘A data citation roadmap for scholarly data repositories,’ Scientific Data 2019, 6, 28.
@rmzelle

rmzelle reviewed Jul 7, 2019
View changes

helvetica-chimica-acta.csl Outdated
<issn>0018-019X</issn>
<eissn>1522-2675</eissn>
<summary>A style for Wiley-VCH's journal "Helvetica Chimica Acta" based on "Angewandte Chemie International Edition".
This style has many limits due to csl constraints, most notably the inability to include pages/page ranges for books, the wrong square brackets for two items cited together, and the lack of support for citing 1a)... b)...c)....</summary>

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jul 7, 2019

Member

This style has many limits due to csl constraints, most notably the inability to include pages/page ranges for books, the wrong square brackets for two items cited together, and the lack of support for citing 1a)... b)...c)....

@daenuprobst, can you describe the first two problems in more detail? We're aware of the third point, which is indeed currently not possible with CSL (citation-style-language/schema#36).

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jul 15, 2019

Member
  1. Refers to providing essentially a pinpoint to a specific passage in a book in a numeric style. CSL can kind of do this by using text variable="page" but that requires separate items every time you want to add a different part of a book, so isn't really feasible. That said, this isn't actually used in the style or in published articles, so removing it from the summary
  2. The style using [1-2] instead of [1,2] which CSL can't do
  3. The style explicitly does not use composit (1a) b) c)) references, so I'll take this out of the summary, too.
@adam3smith
Some clean-up
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d86886c
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 15, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

helvetica-chimica-acta.csl (new)
[1,2]
[3,4]
[1]B. Hancké, M. Rhodes, M. Thatcher, Eds. , Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy, Oxford University Press, Oxford and New York, 2007.
[2]“CSL search by example,” can be found under http://editor.citationstyles.org/searchByExample/, 2012.
[3]I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (Eds.: P.A. Hall, D. Soskice), Oxford University Press, New York, 2001, pp. 184–213.
[4]M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, et al., “A data citation roadmap for scholarly data repositories,” Scientific Data 2019, 6, 28.
@adam3smith
fix bold year
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
88b5dad
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 15, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

helvetica-chimica-acta.csl (new)
[1,2]
[3,4]
[1]B. Hancké, M. Rhodes, M. Thatcher, Eds. , Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy, Oxford University Press, Oxford and New York, 2007.
[2]“CSL search by example,” can be found under http://editor.citationstyles.org/searchByExample/, 2012.
[3]I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage (Eds.: P.A. Hall, D. Soskice), Oxford University Press, New York, 2001, pp. 184–213.
[4]M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, “A data citation roadmap for scholarly data repositories,” Scientific Data 2019, 6, 28.

@adam3smith adam3smith merged commit d14b62d into citation-style-language:master Jul 15, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 15, 2019

Great, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.