Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create heidelberg-university-faculty-of-medicine.csl #2517

Merged
merged 6 commits into from Feb 21, 2017

Conversation

Projects
None yet
3 participants
@POBrien333
Copy link
Contributor

commented Feb 19, 2017

via https://forums.zotero.org/discussion/63264/style-request-promotion-uni-heidelberg-german

Waiting to hear regarding the language, if it'll be German or English or both.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 19, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Feb 19, 2017

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

commented Feb 19, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 20, 2017

😃 Your submission passed all our automated tests.

<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" page-range-format="expanded" demote-non-dropping-particle="never">
<info>
<title>Heidelberg University - Faculty of Medicine</title>

This comment has been minimized.

Copy link
@rmzelle

rmzelle Feb 21, 2017

Member

For this type of styles we sometimes include the title in both languages, so that they're easier to find by search, see e.g.:

https://github.com/citation-style-language/styles/blob/master/universita-di-bologna-lettere.csl
<title>University of Bologna - Liberal Arts College (Università di Bologna - Facoltà di Lettere e Filosofia) (Italian)</title>

https://github.com/citation-style-language/styles/blob/master/european-journal-of-ultrasound.csl
<title>European Journal of Ultrasound (Ultraschall in der Medizin)</title>

https://github.com/citation-style-language/styles/blob/master/veterinary-medicine-austria.csl
<title>Veterinary Medicine Austria (Wiener Tierärztliche Monatsschrift)</title>

https://github.com/citation-style-language/styles/blob/master/the-institute-of-electronics-information-and-communication-engineers.csl
<title>The Institute of Electronics, Information and Communication Engineers (電子情報通信学会)</title>

Alternative, we could create a dependent for the other locale, and fixed both versions to their respective locales.

I guess the German title would be "Universität Heidelberg - Medizinische Fakultät Heidelberg" (there is a "Medizinische Fakultät Mannheim", and I'm not sure it uses the same style; https://www.umm.uni-heidelberg.de/home/)

This comment has been minimized.

Copy link
@POBrien333

POBrien333 Feb 21, 2017

Author Contributor

The VetMed Austria style is the one that got me into CSL in 2011 and then reintroduced me couple of months ago to fix some outstanding mistakes. ;)

@@ -0,0 +1,323 @@
<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" page-range-format="expanded" demote-non-dropping-particle="never">

This comment has been minimized.

Copy link
@rmzelle

rmzelle Feb 21, 2017

Member

I also have been adding an XML comment to polyglot styles, so it's clear later why certain styles don't have a "default-locale". See https://github.com/citation-style-language/styles/search?utf8=%E2%9C%93&q=polyglot (an example is <!-- Polyglot; used both with German and English -->)

@csl-bot

This comment has been minimized.

Copy link

commented Feb 21, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 21, 2017

😃 Your submission passed all our automated tests.

<updated>2017-02-19T19:17:48+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en-GB">

This comment has been minimized.

Copy link
@rmzelle

rmzelle Feb 21, 2017

Member

@damnation333, if you leave out the "default-locale", I would change this to <locale xml:lang="en">, otherwise people who use it with "en-US" won't see the effects of this locale block.

</term>
</terms>
</locale>
<locale xml:lang="de-DE">

This comment has been minimized.

Copy link
@rmzelle

rmzelle Feb 21, 2017

Member

Less important, but you can just use xml:lang="de" here, too.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 21, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit bc29e79 into citation-style-language:master Feb 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Feb 21, 2017

Danke sehr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.