Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Mediaeval Studies style #3954

Merged
merged 7 commits into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@adunning
Copy link
Contributor

commented Feb 25, 2019

Style for the journal Mediaeval Studies.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 25, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Feb 25, 2019

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith
Copy link
Member

left a comment

A couple of comments. You'll also need to delete the following macros:
"access", "access-note", "container-contributors", "container-title", "contributors", "contributors-...", "locators-journal-join-with-colon", "locators-journal-join-with-comma", "secondary-contributors"
which are unused.

Finally, could you briefly say how this differs from regular Chicago?

Show resolved Hide resolved mediaeval-studies.csl Outdated
Show resolved Hide resolved mediaeval-studies.csl Outdated
Show resolved Hide resolved mediaeval-studies.csl Outdated
@adunning

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

According to the website, it's identical to Chicago, but without publisher names or URLs. Should we not bother with a separate style?

@adam3smith

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

no publisher names is a pretty significant change, we'll need a separate style.

@stale

This comment has been minimized.

Copy link

commented Mar 29, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Mar 29, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@adunning it'd be great if you could make the couple of adjustments as per the above.

@stale stale bot removed the waiting label Mar 29, 2019

@stale

This comment has been minimized.

Copy link

commented Apr 28, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Apr 28, 2019

@stale stale bot closed this May 12, 2019

@adunning

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Have applied requested changes, if you can reassess.

@adam3smith adam3smith reopened this May 16, 2019

@stale stale bot removed the waiting label May 16, 2019

@csl-bot

This comment has been minimized.

Copy link

commented May 16, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented May 16, 2019

😟 There are some issues with your submission. Please check the test report for details.

@adunning

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

It's quite confusing that the online CSL Validator doesn't pick up the same errors as Travis.

@csl-bot

This comment has been minimized.

Copy link

commented May 16, 2019

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

commented May 16, 2019

we run a set of additional tests beyond validation on styles for the repository -- naming, macros, etc. -- that aren't caught by just validation against the CSL schema. It's generally possible to run tests locally, but that's probably not worth it for

@csl-bot

This comment has been minimized.

Copy link

commented May 16, 2019

😟 There are some issues with your submission. Please check the test report for details.

@adunning

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

I've gone through the process five times now, and it simply finds more errors each time that it didn't mention before. How does one deal with this normally?

@csl-bot

This comment has been minimized.

Copy link

commented May 16, 2019

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

commented May 16, 2019

I'm guessing that the macros you deleted contained the only call to other macros, which is why new issues came up. There's not a particularly easy way to handle this beyond checking this.

@csl-bot

This comment has been minimized.

Copy link

commented May 16, 2019

😃 Your submission passed all our automated tests.

@adunning

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Obviously it likes you better.

@adam3smith adam3smith merged commit f5b049d into citation-style-language:master Jun 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Thanks!

@adunning adunning deleted the adunning:patch-4 branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.