Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate Mediaeval Studies style #3954
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Feb 25, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Feb 25, 2019
|
adam3smith
requested changes
Feb 27, 2019
A couple of comments. You'll also need to delete the following macros: Finally, could you briefly say how this differs from regular Chicago? |
This comment has been minimized.
This comment has been minimized.
According to the website, it's identical to Chicago, but without publisher names or URLs. Should we not bother with a separate style? |
This comment has been minimized.
This comment has been minimized.
no publisher names is a pretty significant change, we'll need a separate style. |
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Mar 29, 2019
This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks. |
stale
bot
added
the
waiting
label
Mar 29, 2019
This comment has been minimized.
This comment has been minimized.
@adunning it'd be great if you could make the couple of adjustments as per the above. |
stale
bot
removed
the
waiting
label
Mar 29, 2019
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Apr 28, 2019
This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks. |
stale
bot
added
the
waiting
label
Apr 28, 2019
stale
bot
closed this
May 12, 2019
This comment has been minimized.
This comment has been minimized.
Have applied requested changes, if you can reassess. |
adam3smith
reopened this
May 16, 2019
stale
bot
removed
the
waiting
label
May 16, 2019
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 16, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 16, 2019
|
This comment has been minimized.
This comment has been minimized.
It's quite confusing that the online CSL Validator doesn't pick up the same errors as Travis. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 16, 2019
|
This comment has been minimized.
This comment has been minimized.
we run a set of additional tests beyond validation on styles for the repository -- naming, macros, etc. -- that aren't caught by just validation against the CSL schema. It's generally possible to run tests locally, but that's probably not worth it for |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 16, 2019
|
This comment has been minimized.
This comment has been minimized.
I've gone through the process five times now, and it simply finds more errors each time that it didn't mention before. How does one deal with this normally? |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 16, 2019
|
This comment has been minimized.
This comment has been minimized.
I'm guessing that the macros you deleted contained the only call to other macros, which is why new issues came up. There's not a particularly easy way to handle this beyond checking this. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 16, 2019
|
This comment has been minimized.
This comment has been minimized.
Obviously it likes you better. |
adam3smith
merged commit f5b049d
into
citation-style-language:master
Jun 7, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks! |
adunning commentedFeb 25, 2019
•
edited
Style for the journal Mediaeval Studies.