New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create university-of-aleppo-faculty-of-medicine.csl #4077

Closed

firasuke wants to merge 1 commit into citation-style-language:master from unknown repository

+97 −0

firasuke commented May 4, 2019

Created for use in articles, dissertations and theses in the Faculty of Medicine at the University of Aleppo


      Create university-of-aleppo-faculty-of-medicine.csl

8cf28e4

csl-bot commented May 4, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

csl-bot commented May 4, 2019

😃 Your submission passed all our automated tests.

Member

adam3smith commented May 8, 2019

Thanks! We would really like some sort of documentation for this style before publishing it -- could be a link or you could upload a document here (note that you need to do it on the site -- email attachments won't work)

Author

firasuke commented May 9, 2019

Here's a link to the style's documentation.

adam3smith requested changes May 10, 2019

View changes

Member

adam3smith left a comment

Thanks! A couple of small, mostly stylistic, change requests.

university-of-aleppo-faculty-of-medicine.csl

  
          </info>

          <macro name="author">

            <names variable="author">

              <name initialize-with=". " name-as-sort-order="all" sort-separator=" "/>

adam3smith May 10, 2019

Member

what about edited books?

university-of-aleppo-faculty-of-medicine.csl

  
            <text variable="publisher"/>

          </macro>

          <macro name="edition">

            <number vertical-align="baseline" suffix=" ed. " variable="edition" form="ordinal"/>

adam3smith May 10, 2019

Member

no need for the vertical-align. Better to use a term instead of a suffix for edition. Also, good to account for non-number editions (e.g. "completely revised 2nd edition")

university-of-aleppo-faculty-of-medicine.csl

  
            <number vertical-align="baseline" suffix=" ed. " variable="edition" form="ordinal"/>

          </macro>

          <macro name="publisher-place">

            <text variable="publisher-place" suffix=". "/>

adam3smith May 10, 2019

Member

Move the suffix into the bibliography for consistency

firasuke May 10, 2019

Author

Done

university-of-aleppo-faculty-of-medicine.csl

  
            <text variable="issue"/>

          </macro>

          <macro name="container-title">

            <text variable="container-title" suffix=". "/>

adam3smith May 10, 2019

Member

Move the suffix into the bibliography for consistency

firasuke May 10, 2019

Author

Done

university-of-aleppo-faculty-of-medicine.csl

  
              <key variable="citation-number"/>

            </sort>

            <layout vertical-align="sup" delimiter="، " prefix="[" suffix="]">

              <text variable="citation-number" vertical-align="sup"/>

adam3smith May 10, 2019

Member

No need for the vertical-align here; it's inherited from layout.

firasuke May 10, 2019

Author

Ok

university-of-aleppo-faculty-of-medicine.csl

  
            <sort>

              <key variable="citation-number"/>

            </sort>

            <layout vertical-align="sup" delimiter="، " prefix="[" suffix="]">

adam3smith May 10, 2019

Member

Is that really supposed to be an inverted comma as delimiter?

firasuke May 10, 2019

Author

Yes, the use of the inverted comma is intended.

university-of-aleppo-faculty-of-medicine.csl

  
          <macro name="isbn">

            <text variable="ISBN" prefix="ISBN: "/>

          </macro>

          <citation initialize="false">

adam3smith May 10, 2019

Member

remove initialize here. typically you'll want to add a collapse="citation-number" here to get [1-4] instead of [1, 2, 3, 4]

firasuke May 10, 2019

Author

I purposely avoided the use of collapse since it doesn't work well with right-to-left languages.

university-of-aleppo-faculty-of-medicine.csl

  
            </sort>

            <layout>

              <text variable="citation-number" vertical-align="baseline" prefix="[" suffix="] "/>

              <text macro="author" text-decoration="none" suffix=". "/>

adam3smith May 10, 2019

Member

Use a group with delimiter=". " instead of all the suffixes.

firasuke May 10, 2019

Author

Done

university-of-aleppo-faculty-of-medicine.csl

  
              <key variable="author"/>

            </sort>

            <layout>

              <text variable="citation-number" vertical-align="baseline" prefix="[" suffix="] "/>

adam3smith May 10, 2019

Member

No need for the vertical-align

firasuke May 10, 2019

Author

Ok

university-of-aleppo-faculty-of-medicine.csl

  
            <title>University of Aleppo - Faculty of Medicine</title>

            <title-short>UAFM</title-short>

            <id>http://www.zotero.org/styles/university-of-aleppo-faculty-of-medicine</id>

            <link rel="self" href="http://www.zotero.org/styles/university-of-aleppo-faculty-of-medicine"/>

adam3smith May 10, 2019

Member

add a link with rel="documentation" to the documentation you created

firasuke May 10, 2019

Author

Done

Author

firasuke commented May 10, 2019

I applied most of the requested changes on the style; however, I wasn't able to apply them on this pull request as the 'Edit file' option was greyed out, though I don't know if that's related with me deleting the fork of this repo.

Member

adam3smith commented May 11, 2019

The description of the changes all make sense -- could you point me to the file that has them? For future reference, please don't delete the fork and branch of an active pull request -- that makes it impossible to make any changes, as you can see.

Author

firasuke commented May 11, 2019

Here's a link to the style. Thanks for clarifying, I'll make sure to not remove future forks.

adam3smith closed this in `6eb6c0e` May 16, 2019

Member

adam3smith commented May 16, 2019

Thanks!

Author

firasuke commented May 16, 2019

You're most welcome. Thanks for your valuable comments, fast replies and hard efforts.

Member

rmzelle commented May 27, 2019

@firasuke, could you tell me whether this CSL style is only meant to be used in English?

Member

adam3smith commented May 27, 2019

@rmzelle -- there were specific things in the style to accommodate RTL languages, so I assume not.

Author

firasuke commented May 27, 2019

@rmzelle, this style is meant to be used only in both English and Arabic; however, and as pointed out by @adam3smith, it was designed with right-to-left languages in mind.

Please do note that citation numbers are delimited by inverted commas and do not collapse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.