Track tasks and feature requests
Join 36 million developers who use GitHub issues to help identify, assign, and keep track of the features and bug fixes your projects need.
Sign up for free See pricing for teams and enterprisesDetectMimeTypeTika.scala - do we actually use it? #330
Comments
ruebot
added a commit
that referenced
this issue
Jul 25, 2019
ruebot
added
clean-up
in progress
labels
Jul 25, 2019
This comment has been minimized.
This comment has been minimized.
I was using it for binary extraction, since the MimeType recorded in the WARCs is not always reliable. (I haven't committed the binary extraction methods yet, in part because I think I was having some Tika related memory issues.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ruebot commentedJul 25, 2019
Following up on the question in Slack.
What's the use case for
DetectMimeTypeTika
? We usegetMimeType
elsewhere, but I a little confused how it actually works.The only thing that I can see that calls it is a test for it.
I was digging through the Git history here and on the Warcbase repo, and can't really tell what it's used for, but it goes way back to Pig days. Maybe it's just legacy and we can remove it?
@lintool @jrwiebe @ianmilligan1 thoughts?