New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of 'filesystem-root relative reference' warning. #251

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
2 participants
@ruebot
Member

ruebot commented Aug 10, 2018

What does this Pull Request do?

Resolves this build warning:

[WARNING] The assembly descriptor contains a filesystem-root relative reference, which is not cross platform compatible /

How should this be tested?

PySpark support should work just fine.

Interested parties

@ianmilligan1 when you have time, can you verify we're good? No rush on this one.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 10, 2018

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files          41       41           
  Lines        1024     1024           
  Branches      191      191           
=======================================
  Hits          718      718           
  Misses        240      240           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efde66...cfb1956. Read the comment docs.

codecov bot commented Aug 10, 2018

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files          41       41           
  Lines        1024     1024           
  Branches      191      191           
=======================================
  Hits          718      718           
  Misses        240      240           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efde66...cfb1956. Read the comment docs.

@ianmilligan1

Tested this branch with our Python scripts and works very well.

screen shot 2018-08-10 at 9 10 35 am

@ianmilligan1 ianmilligan1 merged commit a5fa151 into archivesunleashed:master Aug 10, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 9efde66...cfb1956
Details
codecov/project 70.11% remains the same compared to 9efde66
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the ruebot:filesystem-root-relative-reference branch Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment